linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Steve Dickson <steved@redhat.com>
Cc: linux-nfs@vger.kernel.org, NeilBrown <neilb@suse.de>
Subject: [PATCH 4/6] v4set_root: force "fsid=0" for all exports of '/'
Date: Tue, 24 Apr 2012 15:46:38 +1000	[thread overview]
Message-ID: <20120424054638.20130.5981.stgit@notabene.brown> (raw)
In-Reply-To: <20120424054003.20130.16209.stgit@notabene.brown>

When "fsid=0" is not explicitly given in /etc/exports,
v4set_root creates a pseudo (NFSEXP_V4ROOT) export for '/'
with fsid 0 so that an NFSv4 client can find the root.

However if '/' is explicitly exported to the client, then that
explicit export must be used, and it will not have fsid=0.
So we must impose fsid=0 on all exports of '/'.
Without this, if '/' is exported to a client, that client will
not be able to mount '/' with NFSv4.

Signed-off-by: NeilBrown <neilb@suse.de>
---

 utils/mountd/v4root.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/utils/mountd/v4root.c b/utils/mountd/v4root.c
index 81f813b..b4fdcce 100644
--- a/utils/mountd/v4root.c
+++ b/utils/mountd/v4root.c
@@ -192,6 +192,13 @@ v4root_set()
 				 */
 				continue;
 
+			if (strcmp(exp->m_export.e_path, "/") == 0 &&
+			    !(exp->m_export.e_flags & NFSEXP_FSID)) {
+				/* Force '/' to be exported as fsid == 0*/
+				exp->m_export.e_flags |= NFSEXP_FSID;
+				exp->m_export.e_fsid = 0;
+			}
+
 			v4root_add_parents(exp);
 			/* XXX: error handling! */
 		}



  parent reply	other threads:[~2012-04-24  5:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24  5:46 [PATCH 0/6] fix some problems with v4root handling in mountd Neil Brown
2012-04-24  5:46 ` [PATCH 6/6] v4_root_add_parents: remove a possible buffer overflow Neil Brown
2012-04-24  5:46 ` [PATCH 1/6] lookup_export: really prefer nonV4ROOT exports Neil Brown
2012-04-24  5:46 ` [PATCH 5/6] v4root: set the time-to-live for V4ROOT exports to the DEFAULT Neil Brown
2012-04-24  5:46 ` [PATCH 2/6] auth_authenticate_newcache: prefer non-V4ROOT export over V4ROOT exports Neil Brown
2012-04-24  5:46 ` [PATCH 3/6] nfsd_fh: if two exports are possible, choose the one without V4ROOT Neil Brown
2012-04-24  5:46 ` Neil Brown [this message]
2012-04-24 22:03   ` [PATCH 4/6] v4set_root: force "fsid=0" for all exports of '/' J. Bruce Fields
2012-04-24 22:05 ` [PATCH 0/6] fix some problems with v4root handling in mountd J. Bruce Fields
2012-05-01 19:33 ` Steve Dickson
2012-05-02  1:23   ` NeilBrown
2012-05-02 10:32     ` Steve Dickson
2012-05-02 23:08       ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120424054638.20130.5981.stgit@notabene.brown \
    --to=neilb@suse.de \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).