From: Jim Rees <rees@umich.edu>
To: Weston Andros Adamson <dros@netapp.com>
Cc: Trond.Myklebust@netapp.com, chuck.lever@oracle.com,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs4: fix referrals on mounts that use IPv6 addrs
Date: Tue, 24 Apr 2012 11:19:24 -0400 [thread overview]
Message-ID: <20120424151924.GA13191@umich.edu> (raw)
In-Reply-To: <1335279471-46782-1-git-send-email-dros@netapp.com>
Weston Andros Adamson wrote:
diff --git a/fs/nfs/nfs4namespace.c b/fs/nfs/nfs4namespace.c
index 9c8eca3..307743d 100644
--- a/fs/nfs/nfs4namespace.c
+++ b/fs/nfs/nfs4namespace.c
@@ -52,6 +52,35 @@ Elong:
}
/*
+ * parse the path component of an nfs path ("<server>:<path>").
+ * nfspath - the "<server>:<path>" string
+ * end - pointer to end of devname component of 'nfspath'
+ * returns NULL on failure
+ */
The comment seems odd to me. You're not parsing the path component, you're
parsing the nfspath to return the path. And the term "devname component"
hasn't been defined anywhere. How about this:
Return the path component of an nfs path ("<server>:<path>").
nfspath - the "<server>:<path>" string
end - pointer to end of nfspath
returns NULL on failure
next prev parent reply other threads:[~2012-04-24 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 14:57 [PATCH] nfs4: fix referrals on mounts that use IPv6 addrs Weston Andros Adamson
2012-04-24 15:19 ` Jim Rees [this message]
2012-04-24 16:20 ` Adamson, Dros
2012-04-24 15:33 ` Myklebust, Trond
2012-04-24 16:17 ` Adamson, Dros
-- strict thread matches above, loose matches on Subject: below --
2012-04-24 15:07 Weston Andros Adamson
2012-04-24 20:35 Weston Andros Adamson
2012-04-24 20:42 ` Myklebust, Trond
2012-04-24 20:50 Weston Andros Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424151924.GA13191@umich.edu \
--to=rees@umich.edu \
--cc=Trond.Myklebust@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=dros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox