From: "J. Bruce Fields" <bfields@fieldses.org>
To: Weston Andros Adamson <dros@netapp.com>
Cc: SteveD@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: add IPv6 addr escaping to fs_location hosts
Date: Fri, 27 Apr 2012 07:25:29 -0400 [thread overview]
Message-ID: <20120427112529.GA14973@fieldses.org> (raw)
In-Reply-To: <1335279577-46822-1-git-send-email-dros@netapp.com>
On Tue, Apr 24, 2012 at 10:59:37AM -0400, Weston Andros Adamson wrote:
> The fs_location->hosts list is split on colons, but this doesn't work when
> IPv6 addresses are used (they contain colons).
> This patch adds the function nfsd4_encode_components_esc() to
> allow the caller to specify escape characters when splitting on 'sep'.
> In order to fix referrals, this patch must be used with the mountd patch
> that similarly fixes IPv6 [] escaping.
Thanks, looks fine, applying with one trivial change:
> - for (; *end && (*end != sep); end++)
> - ; /* Point to end of component */
> + bool found_esc = false;
> +
> + /* try to parse as esc_start, ..., esc_end, sep */
> + if (*str == esc_enter) {
> + for (; *end && (*end != esc_exit); end++);
I kinda like keeping the semicolon on its own line here. Tastes may
differ.
(Also: how did you test this?)
--b.
next prev parent reply other threads:[~2012-04-27 11:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 14:59 [PATCH] nfsd: add IPv6 addr escaping to fs_location hosts Weston Andros Adamson
2012-04-27 11:25 ` J. Bruce Fields [this message]
2012-04-27 11:42 ` Jim Rees
2012-05-01 16:09 ` Adamson, Dros
2012-05-01 17:01 ` J. Bruce Fields
-- strict thread matches above, loose matches on Subject: below --
2012-04-24 15:07 Weston Andros Adamson
2012-04-27 12:48 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427112529.GA14973@fieldses.org \
--to=bfields@fieldses.org \
--cc=SteveD@redhat.com \
--cc=dros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).