From: "J. Bruce Fields" <bfields@fieldses.org>
To: NeilBrown <neilb@suse.de>
Cc: "J. Bruce Fields" <bfields@redhat.com>,
linux-nfs@vger.kernel.org, Jeff Layton <jlayton@redhat.com>
Subject: Re: [PATCH 0/3] Fix use_ipaddr race
Date: Sat, 28 Apr 2012 11:59:17 -0400 [thread overview]
Message-ID: <20120428155917.GA23348@fieldses.org> (raw)
In-Reply-To: <20120428214726.1742c905@notabene.brown>
On Sat, Apr 28, 2012 at 09:47:26PM +1000, NeilBrown wrote:
> On Sat, 28 Apr 2012 07:26:39 -0400 "J. Bruce Fields" <bfields@fieldses.org>
> wrote:
>
> > On Mon, Apr 23, 2012 at 11:04:19AM +1000, NeilBrown wrote:
> > > On Fri, 20 Apr 2012 18:46:15 -0400 "J. Bruce Fields" <bfields@redhat.com>
> > > wrote:
> > >
> > > > mountd: unconditionally resolve ip address
> > >
> > > Not a good idea. If /etc/exports only contains IP address and subnets, then
> > > we don't ever want to do any address resolution. The "resolve ip address"
> > > must at least be conditional on "are there any domain-name, wild-cards,
> > > netgroups in /etc/exports".
> >
> > The bug is my changelog. All we're really doing there is parsing the ip
> > address, not resolving anything.
>
> Ahhh. I see that now. Thanks.
>
> >
> > ...
> > > > mountd: ignore use_ipaddr and just try both client types
> > >
> > > Maybe ... though if we could syntactically distinguish "use_ipaddr" domains
> > > from "!use_ipaddr" domain and still just choose one test to perform, I think
> > > I'd prefer that.
> >
> > Hm, OK. Something like the following? (Totally untested.)
>
> Yes, that looks good.
>
> I could probably bike-shed for a while about the leading '?', and wonder if
> '!' or '$' might be better choices, or if leading '[' and trailing ']' is
> best but I won't. He who writes the code makes the choice.
Hah. I think I had some vague idea like "the ? reminds us there's still
some question to be answered about this". Anyway, my one worry is that
I'm not sure what the syntax of the existing client types.
Hm, the documentation says "?" and "[character set]" can be used in
wildcard domains, so maybe we do want '!' or '$'.
--b.
next prev parent reply other threads:[~2012-04-28 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 22:46 [PATCH 0/3] Fix use_ipaddr race J. Bruce Fields
2012-04-20 22:46 ` [PATCH 1/3] mountd: unconditionally resolve ip address J. Bruce Fields
2012-04-20 22:46 ` [PATCH 2/3] mountd: helper function for export upcall's client matching J. Bruce Fields
2012-04-20 22:46 ` [PATCH 3/3] mountd: ignore use_ipaddr and just try both client types J. Bruce Fields
2012-04-23 1:04 ` [PATCH 0/3] Fix use_ipaddr race NeilBrown
2012-04-28 11:26 ` J. Bruce Fields
2012-04-28 11:28 ` [PATCH 1/3] mountd: parse ip address earlier J. Bruce Fields
2012-04-28 11:28 ` [PATCH 2/3] mountd: add trivial helpers for client-matching J. Bruce Fields
2012-04-28 11:28 ` [PATCH 3/3] mountd: prepend '?' to make use_ipaddr clients self-describing J. Bruce Fields
2012-04-28 11:47 ` [PATCH 0/3] Fix use_ipaddr race NeilBrown
2012-04-28 15:59 ` J. Bruce Fields [this message]
2012-05-02 1:41 ` J. Bruce Fields
2012-05-02 1:43 ` [PATCH 1/3] mountd: parse ip address earlier J. Bruce Fields
2012-05-02 1:43 ` [PATCH 2/3] mountd: add trivial helpers for client-matching J. Bruce Fields
2012-05-02 1:43 ` [PATCH 3/3] mountd: prepend '$' to make use_ipaddr clients self-describing J. Bruce Fields
2012-05-02 2:07 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120428155917.GA23348@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).