From: Jeff Layton <jlayton@redhat.com>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/6] nfsd4: preserve __user annotation on cld downcall msg
Date: Tue, 1 May 2012 11:53:22 -0400 [thread overview]
Message-ID: <20120501115322.0f8f45a9@corrin.poochiereds.net> (raw)
In-Reply-To: <1335887149-30420-4-git-send-email-bfields@redhat.com>
On Tue, 1 May 2012 11:45:46 -0400
"J. Bruce Fields" <bfields@redhat.com> wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
>
> Cc: Jeff Layton <jlayton@redhat.com>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> ---
> fs/nfsd/nfs4recover.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> index 2b8e9a9..260d8c8 100644
> --- a/fs/nfsd/nfs4recover.c
> +++ b/fs/nfsd/nfs4recover.c
> @@ -570,7 +570,7 @@ static ssize_t
> cld_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
> {
> struct cld_upcall *tmp, *cup;
> - struct cld_msg *cmsg = (struct cld_msg *)src;
> + struct cld_msg __user *cmsg = (struct cld_msg __user *)src;
> uint32_t xid;
> struct nfsd_net *nn = net_generic(filp->f_dentry->d_sb->s_fs_info,
> nfsd_net_id);
Good catch...
Reviewed-by: Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2012-05-01 15:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 15:45 J. Bruce Fields
2012-05-01 15:45 ` [PATCH 1/6] nfsd: state.c should include current_stateid.h J. Bruce Fields
2012-05-01 15:45 ` [PATCH 2/6] nfsd4: fix missing "static" J. Bruce Fields
2012-05-01 15:45 ` [PATCH 3/6] nfsd4: preserve __user annotation on cld downcall msg J. Bruce Fields
2012-05-01 15:53 ` Jeff Layton [this message]
2012-05-01 15:45 ` [PATCH 4/6] nfsd4: int/__be32 fixes J. Bruce Fields
2012-05-01 15:45 ` [PATCH 5/6] nfsd4: fix free_stateid return endianness J. Bruce Fields
2012-05-01 15:45 ` [PATCH 6/6] nfsd4: fix change attribute endianness J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120501115322.0f8f45a9@corrin.poochiereds.net \
--to=jlayton@redhat.com \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).