From: NeilBrown <neilb@suse.de>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: steved@redhat.com, linux-nfs@vger.kernel.org,
Jeff Layton <jlayton@redhat.com>
Subject: Re: [PATCH 3/3] mountd: prepend '$' to make use_ipaddr clients self-describing
Date: Wed, 2 May 2012 12:07:12 +1000 [thread overview]
Message-ID: <20120502120712.13b15f9a@notabene.brown> (raw)
In-Reply-To: <1335923014-2789-3-git-send-email-bfields@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
On Tue, 1 May 2012 21:43:34 -0400 "J. Bruce Fields" <bfields@redhat.com>
wrote:
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index 6cc58d2..1833b3a 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -551,7 +551,7 @@ static void nfsd_fh(FILE *f)
>
> auth_reload();
>
> - if (use_ipaddr) {
> + if (dom[0] == '$') {
if (is_ipaddr_client(dom)) {
??
Otherwise:
Reviewed-by: NeilBrown <neilb@suse.de>
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-05-02 2:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 22:46 [PATCH 0/3] Fix use_ipaddr race J. Bruce Fields
2012-04-20 22:46 ` [PATCH 1/3] mountd: unconditionally resolve ip address J. Bruce Fields
2012-04-20 22:46 ` [PATCH 2/3] mountd: helper function for export upcall's client matching J. Bruce Fields
2012-04-20 22:46 ` [PATCH 3/3] mountd: ignore use_ipaddr and just try both client types J. Bruce Fields
2012-04-23 1:04 ` [PATCH 0/3] Fix use_ipaddr race NeilBrown
2012-04-28 11:26 ` J. Bruce Fields
2012-04-28 11:28 ` [PATCH 1/3] mountd: parse ip address earlier J. Bruce Fields
2012-04-28 11:28 ` [PATCH 2/3] mountd: add trivial helpers for client-matching J. Bruce Fields
2012-04-28 11:28 ` [PATCH 3/3] mountd: prepend '?' to make use_ipaddr clients self-describing J. Bruce Fields
2012-04-28 11:47 ` [PATCH 0/3] Fix use_ipaddr race NeilBrown
2012-04-28 15:59 ` J. Bruce Fields
2012-05-02 1:41 ` J. Bruce Fields
2012-05-02 1:43 ` [PATCH 1/3] mountd: parse ip address earlier J. Bruce Fields
2012-05-02 1:43 ` [PATCH 2/3] mountd: add trivial helpers for client-matching J. Bruce Fields
2012-05-02 1:43 ` [PATCH 3/3] mountd: prepend '$' to make use_ipaddr clients self-describing J. Bruce Fields
2012-05-02 2:07 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502120712.13b15f9a@notabene.brown \
--to=neilb@suse.de \
--cc=bfields@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).