linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: steved@redhat.com, linux-nfs@vger.kernel.org,
	Jeff Layton <jlayton@redhat.com>, NeilBrown <neilb@suse.de>
Subject: Re: [PATCH 2/5] mountd: parse ip address earlier
Date: Wed, 2 May 2012 17:40:50 -0400	[thread overview]
Message-ID: <20120502214049.GA11858@fieldses.org> (raw)
In-Reply-To: <1335994675-11751-3-git-send-email-bfields@redhat.com>

On Wed, May 02, 2012 at 05:37:52PM -0400, J. Bruce Fields wrote:
> @@ -1057,13 +1066,8 @@ static void nfsd_export(FILE *f)
>  
>  	auth_reload();
>  
> -	if (use_ipaddr) {
> -		struct addrinfo *tmp;
> -		tmp = host_pton(dom);
> -		if (tmp == NULL)
> -			goto out;
> -		ai = client_resolve(tmp->ai_addr);
> -		freeaddrinfo(tmp);
> +	if (is_ipaddr_client(dom)) {

Sorry, this is in the wrong patch; resending in a moment.

--b.

> +		ai = lookup_client_addr(dom);
>  		if (!ai)
>  			goto out;
>  	}
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-05-02 21:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-02 21:37 use_ipaddr fixes J. Bruce Fields
2012-05-02 21:37 ` [PATCH 1/5] mountd: fix export upcall failure in use_ipaddr case J. Bruce Fields
2012-05-02 21:37 ` [PATCH 2/5] mountd: parse ip address earlier J. Bruce Fields
2012-05-02 21:40   ` J. Bruce Fields [this message]
2012-05-02 21:37 ` [PATCH 3/5] mountd: add trivial helpers for client-matching J. Bruce Fields
2012-05-02 21:37 ` [PATCH 4/5] mountd: prepend '$' to make use_ipaddr clients self-describing J. Bruce Fields
2012-05-02 21:37 ` [PATCH 5/5] mountd: handle allocation failures in auth_unix_ip upcall J. Bruce Fields
  -- strict thread matches above, loose matches on Subject: below --
2012-05-02 21:56 use_ipaddr fixes version surely-that's-enough J. Bruce Fields
2012-05-02 21:56 ` [PATCH 2/5] mountd: parse ip address earlier J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120502214049.GA11858@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=bfields@redhat.com \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).