Linux NFS development
 help / color / mirror / Atom feed
From: "Ted Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] ext4: turn on i_version updates by default
Date: Mon, 14 May 2012 13:58:22 -0400	[thread overview]
Message-ID: <20120514175822.GC1439@thunk.org> (raw)
In-Reply-To: <14B38D68-FAE4-444A-BCD9-7EBF7E1BBFE1@dilger.ca>

On Mon, May 14, 2012 at 11:27:42AM -0600, Andreas Dilger wrote:
> > And if it at all possible I'd rather have it be something that Just
> > Works rather than something that requires extra configuration.
> 
> Sure, but this is only useful for NFSv4, but costs everyone using
> ext4 continuous overhead, so it isn't a clear-cut case to enable
> the version just on the thought that NFS might one day be used on
> any particular filesystem.

It's not a matter of "NFSv4 might one day be used"; if we don't turn
on i_version updates until the file system is actually exported via
NFSv4, there would be no deleterious effects.

I always thought that was going to be the plan; that there would be
some flag that would be set in struct super_block when the file system
was exported that would enable i_version updates.

That way we satisfy the "no extra configuration" needed requirement,
which I agree is ideal, but we also don't waste any CPU overhead if
the file system is not exported via NFSv4.  I tried to implement
anything along these lines because I don't care enough, and I don't
use NFSv4 personally....

							- Ted

  reply	other threads:[~2012-05-14 17:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14 14:06 [PATCH] ext4: turn on i_version updates by default J. Bruce Fields
2012-05-14 15:02 ` Andreas Dilger
2012-05-14 15:23   ` J. Bruce Fields
2012-05-14 17:27     ` Andreas Dilger
2012-05-14 17:58       ` Ted Ts'o [this message]
2012-05-14 18:33         ` Josef Bacik
2012-05-14 18:48           ` Jeff Layton
2012-05-14 18:51             ` Josef Bacik
2012-05-14 18:54           ` J. Bruce Fields
2012-05-14 19:05             ` Josef Bacik
2012-05-14 21:27               ` Andreas Dilger
2012-05-15 13:28                 ` Josef Bacik
2012-05-15 17:59                   ` Marco Stornelli
2012-05-15 19:18                     ` J. Bruce Fields
2012-05-15 17:33       ` J. Bruce Fields
2012-05-15 18:50         ` djwong
2012-05-14 23:08   ` Myklebust, Trond
2012-05-14 23:33     ` Andreas Dilger
2012-05-14 23:54       ` J. Bruce Fields
2012-05-15 10:30         ` Jan Kara
2012-05-15 12:35           ` J. Bruce Fields
2012-05-15 14:43             ` Jan Kara
2012-05-15  0:13       ` Myklebust, Trond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120514175822.GC1439@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=bfields@fieldses.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox