From: "J. Bruce Fields" <bfields@fieldses.org>
To: Weston Andros Adamson <dros@netapp.com>
Cc: bjschuma@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: return 0 on reads of fault injection files
Date: Wed, 16 May 2012 17:16:21 -0400 [thread overview]
Message-ID: <20120516211621.GE20487@fieldses.org> (raw)
In-Reply-To: <1336678270-791-1-git-send-email-dros@netapp.com>
On Thu, May 10, 2012 at 03:31:10PM -0400, Weston Andros Adamson wrote:
> debugfs read operations were returning the contents of an uninitialized u64.
Thanks, applied.
>
> Signed-off-by: Weston Andros Adamson <dros@netapp.com>
> ---
> I found this while working on (forthcoming) fault injection tests for
> CB_PATH_DOWN.
Did you ever confirm whether the latest nfsd is setting that flag when
it should be?
--b.
>
> fs/nfsd/fault_inject.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c
> index 46b7696..ab81144 100644
> --- a/fs/nfsd/fault_inject.c
> +++ b/fs/nfsd/fault_inject.c
> @@ -62,6 +62,7 @@ static int nfsd_inject_set(void *op_ptr, u64 val)
>
> static int nfsd_inject_get(void *data, u64 *val)
> {
> + *val = 0;
> return 0;
> }
>
> --
> 1.7.4.4
>
next prev parent reply other threads:[~2012-05-16 21:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 19:31 [PATCH] nfsd: return 0 on reads of fault injection files Weston Andros Adamson
2012-05-16 21:16 ` J. Bruce Fields [this message]
2012-05-16 21:50 ` Adamson, Dros
2012-05-16 21:58 ` J. Bruce Fields
2012-05-16 22:10 ` Adamson, Dros
2012-05-17 11:33 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516211621.GE20487@fieldses.org \
--to=bfields@fieldses.org \
--cc=bjschuma@netapp.com \
--cc=dros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).