ANNOUNCE: nfs-utils-1.2.6 released.

ANNOUNCE: nfs-utils-1.2.6 released.

[Steve Dickson]

New Features in this release:
   * The addition the nfsdcld daemon
   * The addition of the osd_login script which is mandated by the
         pnfs-objects standard
   * The addition of -l option to rpcgssd to enforce legacy behaviour

As well as the usual assorted bug fixes...  

The tarball can only be found at Sourceforge.net since 
still unable to access ftp://ftp.kernel.org (I'm working
on it):
  http://sourceforge.net/projects/nfs

The git tree is at:
   git://linux-nfs.org/nfs-utils

The change log is also only on Sourceforge.net:
   http://sourceforge.net/projects/nfs/files/nfs-utils/1.2.6/Changelog-1.2.6/download

steved.

Re: ANNOUNCE: nfs-utils-1.2.6 released.

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

On Mon, 14 May 2012 15:15:38 -0400 Steve Dickson <SteveD@redhat.com> wrote:

> New Features in this release:
>    * The addition the nfsdcld daemon
>    * The addition of the osd_login script which is mandated by the
>          pnfs-objects standard
>    * The addition of -l option to rpcgssd to enforce legacy behaviour
> 
> As well as the usual assorted bug fixes...  
> 
> The tarball can only be found at Sourceforge.net since 
> still unable to access ftp://ftp.kernel.org (I'm working
> on it):
>   http://sourceforge.net/projects/nfs
> 
> The git tree is at:
>    git://linux-nfs.org/nfs-utils
> 
> The change log is also only on Sourceforge.net:
>    http://sourceforge.net/projects/nfs/files/nfs-utils/1.2.6/Changelog-1.2.6/download
> 
> steved.
>

Thanks Steve.

I noticed that the "default download" was still 1.2.5.

I wondered why and eventually found this:

https://sourceforge.net/apps/trac/sourceforge/ticket/20991

So I took the liberty of making the appropriate change, and now the default
download is 1.2.6.
I hope that's OK.

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: ANNOUNCE: nfs-utils-1.2.6 released.

[Steve Dickson]

On 05/15/2012 12:06 AM, NeilBrown wrote:
> On Mon, 14 May 2012 15:15:38 -0400 Steve Dickson <SteveD@redhat.com> wrote:
> 
>> New Features in this release:
>>    * The addition the nfsdcld daemon
>>    * The addition of the osd_login script which is mandated by the
>>          pnfs-objects standard
>>    * The addition of -l option to rpcgssd to enforce legacy behaviour
>>
>> As well as the usual assorted bug fixes...  
>>
>> The tarball can only be found at Sourceforge.net since 
>> still unable to access ftp://ftp.kernel.org (I'm working
>> on it):
>>   http://sourceforge.net/projects/nfs
>>
>> The git tree is at:
>>    git://linux-nfs.org/nfs-utils
>>
>> The change log is also only on Sourceforge.net:
>>    http://sourceforge.net/projects/nfs/files/nfs-utils/1.2.6/Changelog-1.2.6/download
>>
>> steved.
>>
> 
> Thanks Steve.
> 
> I noticed that the "default download" was still 1.2.5.
> 
> I wondered why and eventually found this:
> 
> https://sourceforge.net/apps/trac/sourceforge/ticket/20991
> 
> So I took the liberty of making the appropriate change, and now the default
> download is 1.2.6.
> I hope that's OK.
Definitely! I was assuming it would automatic change after a period 
of time... Thanks for taking care of it!

steved.
  

Re: ANNOUNCE: nfs-utils-1.2.6 released.

[Jim Rees]

If you're going to use the block layout driver, you'll also want to apply
this patch on top of 1.2.6 to prevent your log from filling with garbage.

>From 76e9f814b0c6a9ef996b14123780bb39f448cafb Mon Sep 17 00:00:00 2001
From: Jim Rees <rees@umich.edu>
Date: Tue, 27 Mar 2012 10:18:39 -0400
Subject: [PATCH 1/2] remove pretty_sig()

This really only works against EMC servers.  There is at least one server
that returns unprintable signatures, which fill the log with garbage (the
spec does not mandate printable signatures).  It could be made more generic,
for example by checking each byte for isprint().  But the signatures are
really only of interest to developers, not admins, so it seems better to
just remove it.

Signed-off-by: Jim Rees <rees@umich.edu>
---
 utils/blkmapd/device-process.c |   29 -----------------------------
 1 file changed, 29 deletions(-)

diff --git a/utils/blkmapd/device-process.c b/utils/blkmapd/device-process.c
index 652a7a8..5fe3dff 100644
--- a/utils/blkmapd/device-process.c
+++ b/utils/blkmapd/device-process.c
@@ -49,28 +49,6 @@
 
 #include "device-discovery.h"
 
-static char *pretty_sig(char *sig, uint32_t siglen)
-{
-	static char rs[100];
-	uint64_t sigval;
-	unsigned int i;
-
-	if (siglen <= sizeof(sigval)) {
-		sigval = 0;
-		for (i = 0; i < siglen; i++)
-			sigval |= ((unsigned char *)sig)[i] << (i * 8);
-		sprintf(rs, "0x%0llx", (unsigned long long) sigval);
-	} else {
-		if (siglen > sizeof rs - 4) {
-			siglen = sizeof rs - 4;
-			sprintf(&rs[siglen], "...");
-		} else
-			rs[siglen] = '\0';
-		memcpy(rs, sig, siglen);
-	}
-	return rs;
-}
-
 uint32_t *blk_overflow(uint32_t * p, uint32_t * end, size_t nbytes)
 {
 	uint32_t *q = p + ((nbytes + 3) >> 2);
@@ -109,9 +87,6 @@ static int decode_blk_signature(uint32_t **pp, uint32_t * end,
 		 * for mapping, then thrown away.
 		 */
 		comp->bs_string = (char *)p;
-		BL_LOG_INFO("%s: si_comps[%d]: bs_length %d, bs_string %s\n",
-			    __func__, i, siglen,
-			    pretty_sig(comp->bs_string, siglen));
 		p += ((siglen + 3) >> 2);
 	}
 	*pp = p;
@@ -152,10 +127,6 @@ read_cmp_blk_sig(struct bl_disk *disk, int fd, struct bl_sig_comp *comp)
 	}
 
 	ret = memcmp(sig, comp->bs_string, siglen);
-	if (!ret)
-		BL_LOG_INFO("%s: %s sig %s at %lld\n", __func__, dev_name,
-			    pretty_sig(sig, siglen),
-			    (long long)comp->bs_offset);
 
  out:
 	if (sig)
-- 
1.7.9.5

Re: ANNOUNCE: nfs-utils-1.2.6 released.

[Steve Dickson]

Hey Jim,

On 05/15/2012 08:20 AM, Jim Rees wrote:
> If you're going to use the block layout driver, you'll also want to apply
> this patch on top of 1.2.6 to prevent your log from filling with garbage.
> 
> From 76e9f814b0c6a9ef996b14123780bb39f448cafb Mon Sep 17 00:00:00 2001
> From: Jim Rees <rees@umich.edu>
> Date: Tue, 27 Mar 2012 10:18:39 -0400
> Subject: [PATCH 1/2] remove pretty_sig()
> 
> This really only works against EMC servers.  There is at least one server
> that returns unprintable signatures, which fill the log with garbage (the
> spec does not mandate printable signatures).  It could be made more generic,
> for example by checking each byte for isprint().  But the signatures are
> really only of interest to developers, not admins, so it seems better to
> just remove it.
> 
> Signed-off-by: Jim Rees <rees@umich.edu>
First let me apologise for dropping this.... I have on idea why
it did not make it on my TODO list... A total space out on my part! 

I just committed it (d68e4b5) and I will make sure its include in
update releases in Fedora.... 

Again, sorry for spacing out... 

steved.

> ---
>  utils/blkmapd/device-process.c |   29 -----------------------------
>  1 file changed, 29 deletions(-)
> 
> diff --git a/utils/blkmapd/device-process.c b/utils/blkmapd/device-process.c
> index 652a7a8..5fe3dff 100644
> --- a/utils/blkmapd/device-process.c
> +++ b/utils/blkmapd/device-process.c
> @@ -49,28 +49,6 @@
>  
>  #include "device-discovery.h"
>  
> -static char *pretty_sig(char *sig, uint32_t siglen)
> -{
> -	static char rs[100];
> -	uint64_t sigval;
> -	unsigned int i;
> -
> -	if (siglen <= sizeof(sigval)) {
> -		sigval = 0;
> -		for (i = 0; i < siglen; i++)
> -			sigval |= ((unsigned char *)sig)[i] << (i * 8);
> -		sprintf(rs, "0x%0llx", (unsigned long long) sigval);
> -	} else {
> -		if (siglen > sizeof rs - 4) {
> -			siglen = sizeof rs - 4;
> -			sprintf(&rs[siglen], "...");
> -		} else
> -			rs[siglen] = '\0';
> -		memcpy(rs, sig, siglen);
> -	}
> -	return rs;
> -}
> -
>  uint32_t *blk_overflow(uint32_t * p, uint32_t * end, size_t nbytes)
>  {
>  	uint32_t *q = p + ((nbytes + 3) >> 2);
> @@ -109,9 +87,6 @@ static int decode_blk_signature(uint32_t **pp, uint32_t * end,
>  		 * for mapping, then thrown away.
>  		 */
>  		comp->bs_string = (char *)p;
> -		BL_LOG_INFO("%s: si_comps[%d]: bs_length %d, bs_string %s\n",
> -			    __func__, i, siglen,
> -			    pretty_sig(comp->bs_string, siglen));
>  		p += ((siglen + 3) >> 2);
>  	}
>  	*pp = p;
> @@ -152,10 +127,6 @@ read_cmp_blk_sig(struct bl_disk *disk, int fd, struct bl_sig_comp *comp)
>  	}
>  
>  	ret = memcmp(sig, comp->bs_string, siglen);
> -	if (!ret)
> -		BL_LOG_INFO("%s: %s sig %s at %lld\n", __func__, dev_name,
> -			    pretty_sig(sig, siglen),
> -			    (long long)comp->bs_offset);
>  
>   out:
>  	if (sig)

Re: ANNOUNCE: nfs-utils-1.2.6 released.

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1791 bytes --]

On Mon, 14 May 2012 15:15:38 -0400 Steve Dickson <SteveD@redhat.com> wrote:

> New Features in this release:
>    * The addition the nfsdcld daemon
>    * The addition of the osd_login script which is mandated by the
>          pnfs-objects standard

Don't you hate it when people don't bother to test all your -rc's, then
report bugs against your final release?  Me too.

  mkdir /tmp/dest
  make DESTDIR=/tmp/dest install

fails because it tries to install osd_login in /tmp/dest/sbin/osd_login
without first creating /tmp/dest/sbin.  All other required directories get
created first.

This patch - stealing an idea from utils/mount - seem to fix it.

Thanks,
NeilBrown


commit 03bb227402ab023f4badb515022d49f82e01ff8d
Author: Neil Brown <neilb@suse.de>
Date:   Thu May 17 16:40:40 2012 +1000

    osd_login - ensure /sbin is created before installation.
    
    If we use a more standard approach to describing the osd_login
    script, the automake infrastructure will create /sbin before
    attempting installation.
    This is important for: make DESTDIR=/empty-dir install
    
    Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/utils/osd_login/Makefile.am b/utils/osd_login/Makefile.am
index adc493a..d17ffa7 100644
--- a/utils/osd_login/Makefile.am
+++ b/utils/osd_login/Makefile.am
@@ -1,12 +1,9 @@
 ## Process this file with automake to produce Makefile.in
 
-OSD_LOGIN_FILES= osd_login
+# These binaries go in /sbin (not /usr/sbin), and that cannot be
+# overriden at config time.
+sbindir = /sbin
 
-EXTRA_DIST= $(OSD_LOGIN_FILES)
-
-all-local: $(OSD_LOGIN_FILES)
-
-install-data-hook:
-	$(INSTALL) --mode 755 osd_login $(DESTDIR)/sbin/osd_login
+sbin_SCRIPTS = osd_login
 
 MAINTAINERCLEANFILES = Makefile.in

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: ANNOUNCE: nfs-utils-1.2.6 released.

[Jim Rees]

NeilBrown wrote:

  On Mon, 14 May 2012 15:15:38 -0400 Steve Dickson <SteveD@redhat.com> wrote:
  
  > New Features in this release:
  >    * The addition the nfsdcld daemon
  >    * The addition of the osd_login script which is mandated by the
  >          pnfs-objects standard
  
  Don't you hate it when people don't bother to test all your -rc's, then
  report bugs against your final release?  Me too.
  
    mkdir /tmp/dest
    make DESTDIR=/tmp/dest install
  
  fails because it tries to install osd_login in /tmp/dest/sbin/osd_login
  without first creating /tmp/dest/sbin.  All other required directories get
  created first.
  
  This patch - stealing an idea from utils/mount - seem to fix it.

Please see my comment in response to Mike Frysinger's similar patch.

Date: Thu, 17 May 2012 07:53:30 -0400
From: Jim Rees <rees@umich.edu>
Subject: Re: [PATCH] osd_login: fix DESTDIR install
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-nfs@vger.kernel.org

You misspelled "overridden."  Yes, I know you just copied this line from
mount/Makefile.am, but there is no sense compounding the error.

Also it might be worth mentioning in the comment why we have this  
restriction.

Re: ANNOUNCE: nfs-utils-1.2.6 released.

[Steve Dickson]

Hey Neil,

On 05/17/2012 02:44 AM, NeilBrown wrote:
> On Mon, 14 May 2012 15:15:38 -0400 Steve Dickson <SteveD@redhat.com> wrote:
> 
>> New Features in this release:
>>    * The addition the nfsdcld daemon
>>    * The addition of the osd_login script which is mandated by the
>>          pnfs-objects standard
> 
> Don't you hate it when people don't bother to test all your -rc's, then
> report bugs against your final release?  Me too.
> 
>   mkdir /tmp/dest
>   make DESTDIR=/tmp/dest install
I'll add this test to that makerel script you gave me way back when... 
So hopefully I'll this type of breakage before I make a release! 
 
> 
> fails because it tries to install osd_login in /tmp/dest/sbin/osd_login
> without first creating /tmp/dest/sbin.  All other required directories get
> created first.
> 
> This patch - stealing an idea from utils/mount - seem to fix it.
Thanks for that patch... Its been applied with the correct spelling
of overridden! ;-) 

steved.

> 
> Thanks,
> NeilBrown
> 
> 
> commit 03bb227402ab023f4badb515022d49f82e01ff8d
> Author: Neil Brown <neilb@suse.de>
> Date:   Thu May 17 16:40:40 2012 +1000
> 
>     osd_login - ensure /sbin is created before installation.
>     
>     If we use a more standard approach to describing the osd_login
>     script, the automake infrastructure will create /sbin before
>     attempting installation.
>     This is important for: make DESTDIR=/empty-dir install
>     
>     Signed-off-by: NeilBrown <neilb@suse.de>
> 
> diff --git a/utils/osd_login/Makefile.am b/utils/osd_login/Makefile.am
> index adc493a..d17ffa7 100644
> --- a/utils/osd_login/Makefile.am
> +++ b/utils/osd_login/Makefile.am
> @@ -1,12 +1,9 @@
>  ## Process this file with automake to produce Makefile.in
>  
> -OSD_LOGIN_FILES= osd_login
> +# These binaries go in /sbin (not /usr/sbin), and that cannot be
> +# overriden at config time.
> +sbindir = /sbin
>  
> -EXTRA_DIST= $(OSD_LOGIN_FILES)
> -
> -all-local: $(OSD_LOGIN_FILES)
> -
> -install-data-hook:
> -	$(INSTALL) --mode 755 osd_login $(DESTDIR)/sbin/osd_login
> +sbin_SCRIPTS = osd_login
>  
>  MAINTAINERCLEANFILES = Makefile.in

Re: ANNOUNCE: nfs-utils-1.2.6 released.

[Sachin Bhamare]

On 5/16/12 11:44 PM, NeilBrown wrote:
> On Mon, 14 May 2012 15:15:38 -0400 Steve Dickson <SteveD@redhat.com> wrote:
> 
>> New Features in this release:
>>    * The addition the nfsdcld daemon
>>    * The addition of the osd_login script which is mandated by the
>>          pnfs-objects standard
> 
> Don't you hate it when people don't bother to test all your -rc's, then
> report bugs against your final release?  Me too.
> 
>   mkdir /tmp/dest
>   make DESTDIR=/tmp/dest install
> 
> fails because it tries to install osd_login in /tmp/dest/sbin/osd_login
> without first creating /tmp/dest/sbin.  All other required directories get
> created first.
> 
> This patch - stealing an idea from utils/mount - seem to fix it.
> 
> Thanks,
> NeilBrown
> 
> 
> commit 03bb227402ab023f4badb515022d49f82e01ff8d
> Author: Neil Brown <neilb@suse.de>
> Date:   Thu May 17 16:40:40 2012 +1000
> 
>     osd_login - ensure /sbin is created before installation.
>     
>     If we use a more standard approach to describing the osd_login
>     script, the automake infrastructure will create /sbin before
>     attempting installation.
>     This is important for: make DESTDIR=/empty-dir install
>     
>     Signed-off-by: NeilBrown <neilb@suse.de>
> 
> diff --git a/utils/osd_login/Makefile.am b/utils/osd_login/Makefile.am
> index adc493a..d17ffa7 100644
> --- a/utils/osd_login/Makefile.am
> +++ b/utils/osd_login/Makefile.am
> @@ -1,12 +1,9 @@
>  ## Process this file with automake to produce Makefile.in
>  
> -OSD_LOGIN_FILES= osd_login
> +# These binaries go in /sbin (not /usr/sbin), and that cannot be
> +# overriden at config time.
> +sbindir = /sbin
>  
> -EXTRA_DIST= $(OSD_LOGIN_FILES)
> -
> -all-local: $(OSD_LOGIN_FILES)
> -
> -install-data-hook:
> -	$(INSTALL) --mode 755 osd_login $(DESTDIR)/sbin/osd_login
> +sbin_SCRIPTS = osd_login
>  
>  MAINTAINERCLEANFILES = Makefile.in

ACK-by: Sachin Bhamare <sbhamare@panasas.com>

Thanks for fixing this. My bad for not testing it with a non-empty DESTDIR.

- sachin

-----
Sachin Bhamare
Panasas Inc.