Linux NFS development
 help / color / mirror / Atom feed
From: Jim Rees <rees@umich.edu>
To: Peng Tao <bergwolf@gmail.com>
Cc: Trond.Myklebust@netapp.com, Boaz Harrosh <bharrosh@panasas.com>,
	linux-nfs@vger.kernel.org, stable@vger.kernel.org,
	Peng Tao <tao.peng@emc.com>
Subject: Re: [PATCH] pnfsblock: bail out partial page IO
Date: Mon, 28 May 2012 15:20:21 -0400	[thread overview]
Message-ID: <20120528192021.GA14447@umich.edu> (raw)
In-Reply-To: <1338228443-4883-1-git-send-email-bergwolf@gmail.com>

Peng Tao wrote:

  Current block layout driver read/write code assumes page
  aligned IO in many places. Add a checker to validate the assumption.

This patch has some problems when compiled for 64 bit.

  CC [M]  fs/nfs/blocklayout/blocklayout.o
/home/rees/src/pnfs/linux/fs/nfs/blocklayout/blocklayout.c: In function ‘bl_read_pagelist’:
/home/rees/src/pnfs/linux/fs/nfs/blocklayout/blocklayout.c:255:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
/home/rees/src/pnfs/linux/fs/nfs/blocklayout/blocklayout.c: In function ‘bl_write_pagelist’:
/home/rees/src/pnfs/linux/fs/nfs/blocklayout/blocklayout.c:578:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
/home/rees/src/pnfs/linux/fs/nfs/blocklayout/blocklayout.c: In function ‘bl_pg_init_read’:
/home/rees/src/pnfs/linux/fs/nfs/blocklayout/blocklayout.c:1017:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
/home/rees/src/pnfs/linux/fs/nfs/blocklayout/blocklayout.c: In function ‘bl_pg_init_write’:
/home/rees/src/pnfs/linux/fs/nfs/blocklayout/blocklayout.c:1026:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]

  reply	other threads:[~2012-05-28 19:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-28 18:07 [PATCH] pnfsblock: bail out partial page IO Peng Tao
2012-05-28 19:20 ` Jim Rees [this message]
2012-05-29  7:07 ` Boaz Harrosh
2012-05-31  3:33   ` tao.peng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120528192021.GA14447@umich.edu \
    --to=rees@umich.edu \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bergwolf@gmail.com \
    --cc=bharrosh@panasas.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tao.peng@emc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox