linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: "Jörg Platte" <jplatte@naasa.net>
Cc: bfields <bfields@fieldses.org>,
	"Myklebust, Trond" <Trond.Myklebust@netapp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	Hans de Bruin <jmdebruin@xmsnet.nl>
Subject: Re: Kernel 3.4.X NFS server regression
Date: Mon, 11 Jun 2012 10:20:16 -0400	[thread overview]
Message-ID: <20120611102016.3114349d@corrin.poochiereds.net> (raw)
In-Reply-To: <E49E5D8F-3647-4B3D-989E-FE4476D37607@naasa.net>

On Mon, 11 Jun 2012 15:25:55 +0200
Jörg Platte <jplatte@naasa.net> wrote:

> Am 11.06.2012 um 15:13 schrieb Jeff Layton <jlayton@redhat.com>:
> 
> > 
> > Ahh, I think I see the bug. From rpc_timeout_upcall_queue:
> > 
> > -----------------------[snip]--------------------------
> >        dentry = dget(pipe->dentry);
> >        spin_unlock(&pipe->lock);
> >        if (dentry) {
> >                rpc_purge_list(&RPC_I(dentry->d_inode)->waitq,
> >                               &free_list, destroy_msg, -ETIMEDOUT);
> >                dput(dentry);
> >        }
> > -----------------------[snip]--------------------------
> > 
> > ...when there is no dentry (as there wouldn't be when rpc_pipefs isn't
> > mounted), then the rpc_purge_list won't run. FWIW, you'd probably see
> > similar problems if you attempted a sec=krb5 mount without having
> > rpc_pipefs mounted.
> > 
> > I'm still looking at the code to see what the right fix is. For now,
> > making sure you have a /var/lib/nfs/v4recoverydir is probably the
> > easiest workaround.
> > 
> > -- 
> > Jeff Layton <jlayton@redhat.com>
> 
> On my computer that shows the bug there is indeed no v4recovery directory. There is one on the other machine that does not show this bug. I'll test the latest kernel with this directory created  today afternoon. 
> 
> Thank you for the analysis!
> 

No problem. One possibility for the difference is that rpc_pipefs is
mounted on the machine that doesn't show the problem, but isn't mouted
on the machine that does.

-- 
Jeff Layton <jlayton@redhat.com>

  reply	other threads:[~2012-06-11 14:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4FD47D4E.9070307@naasa.net>
2012-06-10 11:43 ` Kernel 3.4.X NFS regression Boaz Harrosh
2012-06-10 15:00 ` Kernel 3.4.X NFS server regression Myklebust, Trond
2012-06-11 12:16   ` bfields
2012-06-11 12:39     ` Jeff Layton
2012-06-11 13:13       ` Jeff Layton
2012-06-11 13:25         ` Jörg Platte
2012-06-11 14:20           ` Jeff Layton [this message]
2012-06-11 15:55             ` Joerg Platte
2012-06-11 13:32       ` Boaz Harrosh
2012-06-11 13:44         ` Boaz Harrosh
2012-06-11 14:29           ` Jeff Layton
2012-06-11 15:01             ` Boaz Harrosh
2012-06-11 15:15               ` bfields
2012-06-11 16:25                 ` Boaz Harrosh
2012-06-11 13:51         ` Jeff Layton
2012-06-11 14:05           ` Boaz Harrosh
2012-06-11 14:11             ` Jeff Layton
2012-06-11 14:45               ` Boaz Harrosh
2012-06-11 14:55                 ` Jeff Layton
2012-06-11 15:04                   ` Boaz Harrosh
2012-06-11 14:03   ` [PATCH] rpc_pipefs: allow rpc_purge_list to take a NULL waitq pointer Jeff Layton
2012-06-15 15:24   ` Kernel 3.4.X NFS server regression Joerg Platte
2012-06-15 16:28     ` bfields
2012-06-15 17:19       ` Joerg Platte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120611102016.3114349d@corrin.poochiereds.net \
    --to=jlayton@redhat.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=jmdebruin@xmsnet.nl \
    --cc=jplatte@naasa.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).