From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from cantor2.suse.de ([195.135.220.15]:54204 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756525Ab2FTOVb (ORCPT ); Wed, 20 Jun 2012 10:21:31 -0400 Date: Wed, 20 Jun 2012 15:21:27 +0100 From: Mel Gorman To: Andrew Morton Cc: Linux-MM , Linux-Netdev , Linux-NFS , LKML , David Miller , Trond Myklebust , Neil Brown , Christoph Hellwig , Peter Zijlstra , Mike Christie , Eric B Munson Subject: Re: [PATCH 01/12] netvm: Prevent a stream-specific deadlock Message-ID: <20120620142127.GK4011@suse.de> References: <1340185081-22525-1-git-send-email-mgorman@suse.de> <1340185081-22525-2-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 In-Reply-To: <1340185081-22525-2-git-send-email-mgorman@suse.de> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Jun 20, 2012 at 10:37:50AM +0100, Mel Gorman wrote: > It could happen that all !SOCK_MEMALLOC sockets have buffered so > much data that we're over the global rmem limit. This will prevent > SOCK_MEMALLOC buffers from receiving data, which will prevent userspace > from running, which is needed to reduce the buffered data. > > Fix this by exempting the SOCK_MEMALLOC sockets from the rmem limit. > Once this change it applied, it is important that sockets that set > SOCK_MEMALLOC do not clear the flag until the socket is being torn down. > If this happens, a warning is generated and the tokens reclaimed to > avoid accounting errors until the bug is fixed. > > [davem@davemloft.net: Warning about clearing SOCK_MEMALLOC] > Signed-off-by: Peter Zijlstra > Signed-off-by: Mel Gorman > Acked-by: David S. Miller This patch introduced a new warning that I had previously missed. I'll fix it up when rebasing this series on top of linux-next. -- Mel Gorman SUSE Labs