From: "J. Bruce Fields" <bfields@fieldses.org>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: David Howells <dhowells@redhat.com>,
"Schumaker, Bryan" <Bryan.Schumaker@netapp.com>,
"sct@redhat.com" <sct@redhat.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"steved@redhat.com" <steved@redhat.com>,
"jlayton@redhat.com" <jlayton@redhat.com>
Subject: Re: [PATCH 1/2] NFS: Fix a number of bugs in the idmapper
Date: Tue, 31 Jul 2012 13:11:21 -0400 [thread overview]
Message-ID: <20120731171121.GF27834@fieldses.org> (raw)
In-Reply-To: <20120731163708.GE27834@fieldses.org>
On Tue, Jul 31, 2012 at 12:37:08PM -0400, bfields wrote:
> On Tue, Jul 31, 2012 at 03:07:42PM +0000, Myklebust, Trond wrote:
> > We don't expect people to be running both types of idmapper at the same
> > time. Normally, the distribution will set up one or the other. However
> > if both idmappers do happen to be configured, then we want to always
> > choose the non-legacy type...
>
> On a quick check.... It looks like F17 has /usr/sbin/nfsidmap, and also
> runs rpc.idmapd for the server. While rpc.idmap does have a "-S"
> option, it's not using that.
>
> But that should be easy to fix--I'll go look....
Steve, this, or do we want to modify the default value of RPCIDMAPDARGS
in nfs.sysconfig?
--b.
diff --git a/nfs-idmap.service b/nfs-idmap.service
index 872ae09..93c1b3a 100644
--- a/nfs-idmap.service
+++ b/nfs-idmap.service
@@ -7,7 +7,7 @@ After=nfs-server.service
Type=forking
StandardError=syslog+console
EnvironmentFile=-/etc/sysconfig/nfs
-ExecStart=/usr/sbin/rpc.idmapd $RPCIDMAPDARGS
+ExecStart=/usr/sbin/rpc.idmapd -S $RPCIDMAPDARGS
[Install]
WantedBy=nfs.target
diff --git a/nfs.sysconfig b/nfs.sysconfig
index 2d33cf3..4baa0c3 100644
--- a/nfs.sysconfig
+++ b/nfs.sysconfig
@@ -24,7 +24,7 @@ RPCMOUNTDOPTS=""
STATDARG=""
#
# Optional arguments passed to rpc.idmapd. See rpc.idmapd(8)
-RPCIDMAPDARGS=""
+RPCIDMAPDARGS="-S"
#
# Optional arguments passed to rpc.gssd. See rpc.gssd(8)
RPCGSSDARGS=""
next prev parent reply other threads:[~2012-07-31 17:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 14:42 [PATCH 1/2] NFS: Fix a number of bugs in the idmapper David Howells
2012-07-31 14:42 ` [PATCH 2/2] NFS: Combine the idmapper key types David Howells
2012-07-31 14:54 ` Myklebust, Trond
2012-07-31 15:05 ` David Howells
2012-07-31 14:48 ` [PATCH 1/2] NFS: Fix a number of bugs in the idmapper Myklebust, Trond
2012-07-31 14:56 ` David Howells
2012-07-31 15:07 ` Myklebust, Trond
2012-07-31 16:37 ` J. Bruce Fields
2012-07-31 17:11 ` J. Bruce Fields [this message]
2012-08-01 12:39 ` Steve Dickson
-- strict thread matches above, loose matches on Subject: below --
2012-07-25 15:53 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120731171121.GF27834@fieldses.org \
--to=bfields@fieldses.org \
--cc=Bryan.Schumaker@netapp.com \
--cc=Trond.Myklebust@netapp.com \
--cc=dhowells@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=sct@redhat.com \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).