From: "J. Bruce Fields" <bfields@fieldses.org>
To: bjschuma@netapp.com
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFSD: Swap the struct nfs4_operation getter and setter
Date: Tue, 14 Aug 2012 15:58:43 -0400 [thread overview]
Message-ID: <20120814195843.GA16057@fieldses.org> (raw)
In-Reply-To: <1344974108-24531-1-git-send-email-bjschuma@netapp.com>
On Tue, Aug 14, 2012 at 03:55:08PM -0400, bjschuma@netapp.com wrote:
> From: Bryan Schumaker <bjschuma@netapp.com>
>
> stateid_setter should be matched to op_set_currentstateid, rather than
> op_get_currentstateid.
Why didn't we notice that?
Oh, the two prototypes are actually identical. Eh. OK, applying,
thanks.
--b.
>
> Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
> ---
> fs/nfsd/nfs4proc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index c9c1c0a..f2bb0ef 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -1054,8 +1054,8 @@ struct nfsd4_operation {
> char *op_name;
> /* Try to get response size before operation */
> nfsd4op_rsize op_rsize_bop;
> - stateid_setter op_get_currentstateid;
> - stateid_getter op_set_currentstateid;
> + stateid_getter op_get_currentstateid;
> + stateid_setter op_set_currentstateid;
> };
>
> static struct nfsd4_operation nfsd4_ops[];
> --
> 1.7.11.4
>
prev parent reply other threads:[~2012-08-14 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 19:55 [PATCH] NFSD: Swap the struct nfs4_operation getter and setter bjschuma
2012-08-14 19:58 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814195843.GA16057@fieldses.org \
--to=bfields@fieldses.org \
--cc=bjschuma@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).