* [PATCH] NFSD: Swap the struct nfs4_operation getter and setter
@ 2012-08-14 19:55 bjschuma
2012-08-14 19:58 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: bjschuma @ 2012-08-14 19:55 UTC (permalink / raw)
To: bfields; +Cc: linux-nfs
From: Bryan Schumaker <bjschuma@netapp.com>
stateid_setter should be matched to op_set_currentstateid, rather than
op_get_currentstateid.
Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
---
fs/nfsd/nfs4proc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index c9c1c0a..f2bb0ef 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1054,8 +1054,8 @@ struct nfsd4_operation {
char *op_name;
/* Try to get response size before operation */
nfsd4op_rsize op_rsize_bop;
- stateid_setter op_get_currentstateid;
- stateid_getter op_set_currentstateid;
+ stateid_getter op_get_currentstateid;
+ stateid_setter op_set_currentstateid;
};
static struct nfsd4_operation nfsd4_ops[];
--
1.7.11.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] NFSD: Swap the struct nfs4_operation getter and setter
2012-08-14 19:55 [PATCH] NFSD: Swap the struct nfs4_operation getter and setter bjschuma
@ 2012-08-14 19:58 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2012-08-14 19:58 UTC (permalink / raw)
To: bjschuma; +Cc: linux-nfs
On Tue, Aug 14, 2012 at 03:55:08PM -0400, bjschuma@netapp.com wrote:
> From: Bryan Schumaker <bjschuma@netapp.com>
>
> stateid_setter should be matched to op_set_currentstateid, rather than
> op_get_currentstateid.
Why didn't we notice that?
Oh, the two prototypes are actually identical. Eh. OK, applying,
thanks.
--b.
>
> Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
> ---
> fs/nfsd/nfs4proc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index c9c1c0a..f2bb0ef 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -1054,8 +1054,8 @@ struct nfsd4_operation {
> char *op_name;
> /* Try to get response size before operation */
> nfsd4op_rsize op_rsize_bop;
> - stateid_setter op_get_currentstateid;
> - stateid_getter op_set_currentstateid;
> + stateid_getter op_get_currentstateid;
> + stateid_setter op_set_currentstateid;
> };
>
> static struct nfsd4_operation nfsd4_ops[];
> --
> 1.7.11.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-14 19:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-14 19:55 [PATCH] NFSD: Swap the struct nfs4_operation getter and setter bjschuma
2012-08-14 19:58 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).