From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] knfsd: remove bogus BUG_ON() call from nfsd4_locku
Date: Tue, 21 Aug 2012 14:04:24 -0400 [thread overview]
Message-ID: <20120821180424.GA16497@fieldses.org> (raw)
In-Reply-To: <1345550551-9683-1-git-send-email-jlayton@redhat.com>
On Tue, Aug 21, 2012 at 08:02:31AM -0400, Jeff Layton wrote:
> The code checks for a NULL filp and handles it gracefully just before
> this BUG_ON.
Thanks, applying for 3.6.--b.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> fs/nfsd/nfs4state.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 566a9b7..6e12fd5 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -4294,7 +4294,6 @@ nfsd4_locku(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
> status = nfserr_lock_range;
> goto out;
> }
> - BUG_ON(!filp);
> locks_init_lock(&file_lock);
> file_lock.fl_type = F_UNLCK;
> file_lock.fl_owner = (fl_owner_t)lockowner(stp->st_stateowner);
> --
> 1.7.11.4
>
prev parent reply other threads:[~2012-08-21 18:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 12:02 [PATCH] knfsd: remove bogus BUG_ON() call from nfsd4_locku Jeff Layton
2012-08-21 18:04 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821180424.GA16497@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).