* [PATCH 1/6] fs/nfsd/nfs4idmap.c: adjust inconsistent IS_ERR and PTR_ERR [not found] <1345924629-16584-1-git-send-email-Julia.Lawall@lip6.fr> @ 2012-08-25 19:57 ` Julia Lawall 2012-08-28 1:44 ` J. Bruce Fields 0 siblings, 1 reply; 2+ messages in thread From: Julia Lawall @ 2012-08-25 19:57 UTC (permalink / raw) To: J. Bruce Fields; +Cc: kernel-janitors, linux-nfs, linux-kernel From: Julia Lawall <Julia.Lawall@lip6.fr> Change the call to PTR_ERR to access the value just tested by IS_ERR. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e,e1; @@ ( if (IS_ERR(e)) { ... PTR_ERR(e) ... } | if (IS_ERR(e=e1)) { ... PTR_ERR(e) ... } | *if (IS_ERR(e)) { ... * PTR_ERR(e1) ... } ) // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- fs/nfsd/nfs4idmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c index fdc91a6..11df4ac 100644 --- a/fs/nfsd/nfs4idmap.c +++ b/fs/nfsd/nfs4idmap.c @@ -478,7 +478,7 @@ nfsd_idmap_init(struct net *net) goto destroy_idtoname_cache; nn->nametoid_cache = cache_create_net(&nametoid_cache_template, net); if (IS_ERR(nn->nametoid_cache)) { - rv = PTR_ERR(nn->idtoname_cache); + rv = PTR_ERR(nn->nametoid_cache); goto unregister_idtoname_cache; } rv = cache_register_net(nn->nametoid_cache, net); ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/6] fs/nfsd/nfs4idmap.c: adjust inconsistent IS_ERR and PTR_ERR 2012-08-25 19:57 ` [PATCH 1/6] fs/nfsd/nfs4idmap.c: adjust inconsistent IS_ERR and PTR_ERR Julia Lawall @ 2012-08-28 1:44 ` J. Bruce Fields 0 siblings, 0 replies; 2+ messages in thread From: J. Bruce Fields @ 2012-08-28 1:44 UTC (permalink / raw) To: Julia Lawall; +Cc: kernel-janitors, linux-nfs, linux-kernel On Sat, Aug 25, 2012 at 09:57:04PM +0200, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Change the call to PTR_ERR to access the value just tested by IS_ERR. Applying for 3.7, thanks.--b. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression e,e1; > @@ > > ( > if (IS_ERR(e)) { ... PTR_ERR(e) ... } > | > if (IS_ERR(e=e1)) { ... PTR_ERR(e) ... } > | > *if (IS_ERR(e)) > { ... > * PTR_ERR(e1) > ... } > ) > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > fs/nfsd/nfs4idmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c > index fdc91a6..11df4ac 100644 > --- a/fs/nfsd/nfs4idmap.c > +++ b/fs/nfsd/nfs4idmap.c > @@ -478,7 +478,7 @@ nfsd_idmap_init(struct net *net) > goto destroy_idtoname_cache; > nn->nametoid_cache = cache_create_net(&nametoid_cache_template, net); > if (IS_ERR(nn->nametoid_cache)) { > - rv = PTR_ERR(nn->idtoname_cache); > + rv = PTR_ERR(nn->nametoid_cache); > goto unregister_idtoname_cache; > } > rv = cache_register_net(nn->nametoid_cache, net); > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-28 1:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1345924629-16584-1-git-send-email-Julia.Lawall@lip6.fr>
2012-08-25 19:57 ` [PATCH 1/6] fs/nfsd/nfs4idmap.c: adjust inconsistent IS_ERR and PTR_ERR Julia Lawall
2012-08-28 1:44 ` J. Bruce Fields
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).