* [PATCH] NFSD: pass null terminated buf to kstrtouint()
@ 2012-09-09 15:25 Malahal Naineni
2012-09-10 21:46 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Malahal Naineni @ 2012-09-09 15:25 UTC (permalink / raw)
To: linux-nfs
The 'buf' is prepared with null termination with intention of using it for
this purpose, but 'name' is passed instead!
Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
---
fs/nfsd/nfs4idmap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c
index fdc91a6..ccfe0d0 100644
--- a/fs/nfsd/nfs4idmap.c
+++ b/fs/nfsd/nfs4idmap.c
@@ -598,7 +598,7 @@ numeric_name_to_id(struct svc_rqst *rqstp, int type, const char *name, u32 namel
/* Just to make sure it's null-terminated: */
memcpy(buf, name, namelen);
buf[namelen] = '\0';
- ret = kstrtouint(name, 10, id);
+ ret = kstrtouint(buf, 10, id);
return ret == 0;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NFSD: pass null terminated buf to kstrtouint()
2012-09-09 15:25 [PATCH] NFSD: pass null terminated buf to kstrtouint() Malahal Naineni
@ 2012-09-10 21:46 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2012-09-10 21:46 UTC (permalink / raw)
To: Malahal Naineni; +Cc: linux-nfs
On Sun, Sep 09, 2012 at 10:25:47AM -0500, Malahal Naineni wrote:
> The 'buf' is prepared with null termination with intention of using it for
> this purpose, but 'name' is passed instead!
Thanks!--b.
>
> Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
> ---
> fs/nfsd/nfs4idmap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c
> index fdc91a6..ccfe0d0 100644
> --- a/fs/nfsd/nfs4idmap.c
> +++ b/fs/nfsd/nfs4idmap.c
> @@ -598,7 +598,7 @@ numeric_name_to_id(struct svc_rqst *rqstp, int type, const char *name, u32 namel
> /* Just to make sure it's null-terminated: */
> memcpy(buf, name, namelen);
> buf[namelen] = '\0';
> - ret = kstrtouint(name, 10, id);
> + ret = kstrtouint(buf, 10, id);
> return ret == 0;
> }
>
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-10 21:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-09 15:25 [PATCH] NFSD: pass null terminated buf to kstrtouint() Malahal Naineni
2012-09-10 21:46 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).