linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: trond.myklebust@netapp.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 01/10] NFS: nfs_parsed_mount_options can use unsigned int
Date: Fri, 14 Sep 2012 17:23:14 -0400	[thread overview]
Message-ID: <20120914212313.1635.16943.stgit@degas.1015granger.net> (raw)
In-Reply-To: <20120914211053.1635.74063.stgit@degas.1015granger.net>

fs/nfs/super.c: In function ‘nfs_compare_remount_data’:
fs/nfs/super.c:2042:18: warning: comparison between signed and
    unsigned integer expressions [-Wsign-compare]
fs/nfs/super.c:2043:18: warning: comparison between signed and
    unsigned integer expressions [-Wsign-compare]
fs/nfs/super.c:2044:20: warning: comparison between signed and
    unsigned integer expressions [-Wsign-compare]
fs/nfs/super.c:2046:21: warning: comparison between signed and
    unsigned integer expressions [-Wsign-compare]
fs/nfs/super.c:2047:21: warning: comparison between signed and
    unsigned integer expressions [-Wsign-compare]
fs/nfs/super.c:2048:21: warning: comparison between signed and
    unsigned integer expressions [-Wsign-compare]
fs/nfs/super.c:2049:21: warning: comparison between signed and
    unsigned integer expressions [-Wsign-compare]
fs/nfs/super.c:2050:18: warning: comparison between signed and
    unsigned integer expressions [-Wsign-compare]

Seen with gcc (GCC) 4.6.3 20120306 (Red Hat 4.6.3-2).

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

 fs/nfs/internal.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
index 31fdb03..89560be 100644
--- a/fs/nfs/internal.h
+++ b/fs/nfs/internal.h
@@ -101,11 +101,11 @@ struct nfs_client_initdata {
  */
 struct nfs_parsed_mount_data {
 	int			flags;
-	int			rsize, wsize;
-	int			timeo, retrans;
-	int			acregmin, acregmax,
+	unsigned int		rsize, wsize;
+	unsigned int		timeo, retrans;
+	unsigned int		acregmin, acregmax,
 				acdirmin, acdirmax;
-	int			namlen;
+	unsigned int		namlen;
 	unsigned int		options;
 	unsigned int		bsize;
 	unsigned int		auth_flavor_len;


  reply	other threads:[~2012-09-14 21:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14 21:23 [PATCH 00/10] 3.7 candidates Chuck Lever
2012-09-14 21:23 ` Chuck Lever [this message]
2012-09-14 21:23 ` [PATCH 02/10] NFS: Slow down state manager after an unhandled error Chuck Lever
2012-09-14 21:23 ` [PATCH 03/10] SUNRPC: Clean up dprintk messages in rpc_pipe.c Chuck Lever
2012-09-14 21:23 ` [PATCH 04/10] SUNRPC: Use __func__ in dprintk() in auth_gss.c Chuck Lever
2012-09-14 21:23 ` [PATCH 05/10] SUNRPC: Refactor rpc_clone_client() Chuck Lever
2012-09-14 21:24 ` [PATCH 06/10] SUNRPC: Introduce rpc_clone_client_set_auth() Chuck Lever
2012-09-14 21:24 ` [PATCH 07/10] NFS: Introduce "migration" mount option Chuck Lever
2012-09-14 21:24 ` [PATCH 08/10] NFS: Use the same nfs_client_id4 for every server Chuck Lever
2012-09-14 21:24 ` [PATCH 09/10] NFS: Discover NFSv4 server trunking when mounting Chuck Lever
2012-09-14 21:24 ` [PATCH 10/10] NFS: Add nfs4_unique_id boot parameter Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120914212313.1635.16943.stgit@degas.1015granger.net \
    --to=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@netapp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).