From: Jim Rees <rees@umich.edu>
To: "Peng, Tao" <tao.peng@emc.com>
Cc: Wei Yongjun <weiyj.lk@gmail.com>,
"Trond.Myklebust@netapp.com" <Trond.Myklebust@netapp.com>,
"yongjun_wei@trendmicro.com.cn" <yongjun_wei@trendmicro.com.cn>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFS: fix the return value of nfs4_blkdev_get()
Date: Tue, 25 Sep 2012 08:46:36 -0400 [thread overview]
Message-ID: <20120925124636.GA26766@umich.edu> (raw)
In-Reply-To: <5DFC6BE3BA248842867E85C73BF94B050B18E564AB@MX41A.corp.emc.com>
Peng, Tao wrote:
> -----Original Message-----
> From: linux-nfs-owner@vger.kernel.org [mailto:linux-nfs-owner@vger.kernel.org] On Behalf Of Wei
> Yongjun
> Sent: Tuesday, September 25, 2012 1:44 PM
> To: Trond.Myklebust@netapp.com
> Cc: yongjun_wei@trendmicro.com.cn; linux-nfs@vger.kernel.org
> Subject: [PATCH] NFS: fix the return value of nfs4_blkdev_get()
>
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function nfs4_blkdev_get() return NULL pointer.
> But the user nfs4_blk_decode_device() check the return value by using
> IS_ERR() and get error code from the return value. So we should better
> change the return value of nfs4_blkdev_get() to return ERR_PTR().
>
Yeah, it is merely mess and should be just removed...
It's leftover debug code. Get rid of it.
prev parent reply other threads:[~2012-09-25 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 5:43 [PATCH] NFS: fix the return value of nfs4_blkdev_get() Wei Yongjun
2012-09-25 7:11 ` Peng, Tao
2012-09-25 7:59 ` yongjun_wei
2012-09-25 12:46 ` Jim Rees [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925124636.GA26766@umich.edu \
--to=rees@umich.edu \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=tao.peng@emc.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).