linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] nfsd: stricter endianness in reply cache hash
@ 2012-10-01 17:35 J. Bruce Fields
  0 siblings, 0 replies; only message in thread
From: J. Bruce Fields @ 2012-10-01 17:35 UTC (permalink / raw)
  To: linux-nfs

Just a dumb patch to make u32/__be32 use more consistent, queuing for
3.7.--b.

commit 46056c57875540e945b9fc84042f2e4d7777b2d3
Author: J. Bruce Fields <bfields@redhat.com>
Date:   Fri Jul 27 11:57:00 2012 -0400

    nfsd: stricter endianness in reply cache hash
    
    Admittedly this is just to shut up sparse; the byte-swapping has no
    effect on the result.
    
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>

diff --git a/fs/nfsd/nfscache.c b/fs/nfsd/nfscache.c
index 2cbac34..6e5b8a8 100644
--- a/fs/nfsd/nfscache.c
+++ b/fs/nfsd/nfscache.c
@@ -29,10 +29,10 @@ static int			cache_disabled = 1;
 /*
  * Calculate the hash index from an XID.
  */
-static inline u32 request_hash(u32 xid)
+static inline u32 request_hash(__be32 xid)
 {
-	u32 h = xid;
-	h ^= (xid >> 24);
+	u32 h = ntohl(xid);
+	h ^= (h >> 24);
 	return h & (HASHSIZE-1);
 }
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-10-01 17:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-01 17:35 [PATCH] nfsd: stricter endianness in reply cache hash J. Bruce Fields

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).