linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: davem@davemloft.net, Trond.Myklebust@netapp.com,
	netdev@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] net: sunrpc: xdr: Change message to pr_debug level
Date: Thu, 4 Oct 2012 16:25:23 +0200	[thread overview]
Message-ID: <201210041625.23710.marex@denx.de> (raw)
In-Reply-To: <1349360495-29325-1-git-send-email-fabio.estevam@freescale.com>

Dear Fabio Estevam,

> commit 49f6189 (SUNRPC: Optimise away unnecessary data moves in
> xdr_align_pages) has added a pr_info that floods dmesg when booting via
> NFS.
> 
> There is also a note in the commit log: "Warning! Contains debugging
> printks!"
> 
> ,so change it to pr_debug instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Reviewed-by: Marek Vasut <marex@denx.de>

> ---
>  net/sunrpc/xdr.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index e30842b..6983efc 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -749,7 +749,7 @@ static unsigned int xdr_align_pages(struct xdr_stream
> *xdr, unsigned int len) xdr_shrink_pagelen(buf, buf->page_len - len);
>  		xdr->nwords = XDR_QUADLEN(buf->len - cur);
>  	} else
> -		pr_info("%s: Optimised away a data move!\n", __func__);
> +		pr_debug("%s: Optimised away a data move!\n", __func__);
>  	return len;
>  }

Best regards,
Marek Vasut

  reply	other threads:[~2012-10-04 14:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-04 14:21 [PATCH] net: sunrpc: xdr: Change message to pr_debug level Fabio Estevam
2012-10-04 14:25 ` Marek Vasut [this message]
2012-10-04 14:51   ` Myklebust, Trond
2012-10-04 14:57     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210041625.23710.marex@denx.de \
    --to=marex@denx.de \
    --cc=Trond.Myklebust@netapp.com \
    --cc=davem@davemloft.net \
    --cc=fabio.estevam@freescale.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).