From: Pavel Roskin <proski-mXXj517/zsQ@public.gmane.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org,
linux-doc@vger.kernel.org,
brcm80211-dev-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H@public.gmane.org,
linux-sctp@vger.kernel.org,
devel-s9riP+hp16TNLxjTenLetw@public.gmane.org,
dev@openvswitch.org, linux-s390@vger.kernel.org,
wimax-BPSAo7wm5JOHVYUYWc+uSQ@public.gmane.org,
linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org,
bridge@lists.linux-foundation.org, lvs-devel@vger.kernel.org,
coreteam@netfilter.org, b43-dev@lists.infradead.org,
cbe-oss-dev@lists.ozlabs.org, devel@driverdev.osuosl.org,
user-mode-linux-devel@lists.sourceforge.net,
devicetree-discuss@lists.ozlabs.org,
davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
netfilter@vger.kernel.org,
user-mode-linux-user@lists.sourceforge.net,
linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org,
linux-parisc@vger.kernel.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, l
Subject: Re: [ath9k-devel] [PATCH net-next 00/21] treewide: Use consistent api style for address testing
Date: Fri, 19 Oct 2012 11:55:17 -0400 [thread overview]
Message-ID: <20121019115517.7b8514a8@mj> (raw)
In-Reply-To: <1350630254.2293.183.camel@edumazet-glaptop>
On Fri, 19 Oct 2012 09:04:14 +0200
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Yes they are some names discrepancies, thats a big deal.
>
> And we have alloc_skb() / kfree_skb() / skb_clone()
>
> Why not skb_alloc() / skb_free() / skb_clone() ?
>
> Some people actually know current code by name of functions, they dont
> want to change their mind and having to grep include files and git log
> to learn the new names of an old function, especially when traveling
> and using a laptop.
I agree.
Also, it makes sense to introduce a more consistent name for a function
when it's improved in some way and the callers need to be adjusted or
re-checked.
That way, the old name can be phased out as the code is made compatible
with the new function.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2012-10-19 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 3:55 [PATCH net-next 00/21] treewide: Use consistent api style for address testing Joe Perches
2012-10-19 7:04 ` Eric Dumazet
2012-10-19 15:55 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121019115517.7b8514a8@mj \
--to=proski-mxxj517/zsq@public.gmane.org \
--cc=b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org \
--cc=b43-dev@lists.infradead.org \
--cc=brcm80211-dev-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=bridge@lists.linux-foundation.org \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=coreteam@netfilter.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=dev@openvswitch.org \
--cc=devel-s9riP+hp16TNLxjTenLetw@public.gmane.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
--cc=users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H@public.gmane.org \
--cc=wimax-BPSAo7wm5JOHVYUYWc+uSQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox