From: "J. Bruce Fields" <bfields@fieldses.org>
To: Bryan Schumaker <bjschuma@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 00/10] NFSD: Improve fault injection
Date: Mon, 26 Nov 2012 11:10:46 -0500 [thread overview]
Message-ID: <20121126161046.GC11860@fieldses.org> (raw)
In-Reply-To: <50B38826.3030902@netapp.com>
On Mon, Nov 26, 2012 at 10:17:58AM -0500, Bryan Schumaker wrote:
> On 11/15/2012 10:00 AM, J. Bruce Fields wrote:
> > On Thu, Nov 15, 2012 at 09:55:24AM -0500, Bryan Schumaker wrote:
> >> On 11/14/2012 05:48 PM, J. Bruce Fields wrote:
> >>> On Tue, Oct 30, 2012 at 04:50:44PM -0400, bjschuma@netapp.com wrote:
> >>>> From: Bryan Schumaker <bjschuma@netapp.com>
> >>>>
> >>>> While working on p2p-nfs, I discovered that I sometimes need to clear
> >>>> state for a specific client to test all possible error recovery conditions.
> >>>> The current fault injection code deletes state as it find it, so it can
> >>>> be difficult to guess which state will be forgotten. In addition, I
> >>>> currently print out the amount of state forgotten but I don't give details
> >>>> like "Forgot 3 locks from client w.x.y.z". These patches set out to
> >>>> improve that.
> >>>>
> >>>> The first 7 patches clean up the current code and prepare it for specific
> >>>> client state removal. Patch 8 adds prints information to the server's logs
> >>>> when a fault injection file is read (such as "Client w.x.y.z has 3 open
> >>>> files"). Patch 9 adds in a custom file operations structure so users can
> >>>> write strings to fault injection files in addition to u64s. Finally, patch
> >>>> 10 allows users to remove state by writing a client's IP address to one of
> >>>> the files.
> >>>
> >>> Apologies for putting you off again, but: I'd like to get Stanislav's
> >>> patches sorted out first. I think that shouldn't take too long--bug me
> >>> in another week or so if I haven't come back to these by then. These
> >>> may need a little rebasing at that point.
> >>
> >> Ok, I'll add "bug Bruce" to my calendar... I took a quick glance through his patches and I don't think rebasing will be too hard.
> >
> > Good, thanks!
>
> So what's the plan for these patches?
I'll need to take a quick look at Stanislav's latest and at these
patches. Some of his stuff is already in my public tree so yours may
already need a rebase?
--b.
next prev parent reply other threads:[~2012-11-26 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 20:50 [PATCH v2 00/10] NFSD: Improve fault injection bjschuma
2012-10-30 20:50 ` [PATCH v2 01/10] NFSD: Fold fault_inject.h into state.h bjschuma
2012-10-30 20:50 ` [PATCH v2 02/10] NFSD: Lock state before calling fault injection function bjschuma
2012-10-30 20:50 ` [PATCH v2 03/10] NFSD: Clean up forgetting clients bjschuma
2012-10-30 20:50 ` [PATCH v2 04/10] NFSD: Clean up forgetting locks bjschuma
2012-10-30 20:50 ` [PATCH v2 05/10] NFSD: Clean up forgetting openowners bjschuma
2012-10-30 20:50 ` [PATCH v2 06/10] NFSD: Clean up forgetting and recalling delegations bjschuma
2012-10-30 20:50 ` [PATCH v2 07/10] NFSD: Fault injection operations take a per-client forget function bjschuma
2012-10-30 20:50 ` [PATCH v2 08/10] NFSD: Reading a fault injection file prints a state count bjschuma
2012-10-30 20:50 ` [PATCH v2 09/10] NFSD: Add a custom file operations structure for fault injection bjschuma
2012-10-30 20:50 ` [PATCH v2 10/10] NFSD: Forget state for a specific client bjschuma
2012-11-14 22:48 ` [PATCH v2 00/10] NFSD: Improve fault injection J. Bruce Fields
2012-11-15 14:55 ` Bryan Schumaker
2012-11-15 15:00 ` J. Bruce Fields
2012-11-26 15:17 ` Bryan Schumaker
2012-11-26 16:10 ` J. Bruce Fields [this message]
2012-11-26 16:26 ` Bryan Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126161046.GC11860@fieldses.org \
--to=bfields@fieldses.org \
--cc=bjschuma@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).