From: NeilBrown <neilb@suse.de>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: NFS <linux-nfs@vger.kernel.org>
Subject: Re: NFS regression - EIO is returned instead of ENOSPC
Date: Wed, 12 Dec 2012 09:53:04 +1100 [thread overview]
Message-ID: <20121212095304.368c9708@notabene.brown> (raw)
In-Reply-To: <20121212092813.23afbc5f@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]
On Wed, 12 Dec 2012 09:28:13 +1100 NeilBrown <neilb@suse.de> wrote:
>
> Hi Trond et al,
> we seem to have a regression introduced by
>
> commit 7b281ee026552f10862b617a2a51acf49c829554
> NFS: fsync() must exit with an error if page writeback failed
>
> which has found it's way (in different form into -stable releases).
Bit of a clarification here. It didn't get into -stable, but we have the bug
in our 3.0 based SLES11-SP2 through a different route (I assumed it came
through stable but was being too hasty).
The bug first arrived in v3.1-rc1
commit 02c24a82187d5a628c68edfe71ae60dc135cd178
fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers
was fixed by me in v3.3-rc1
commit 2edb6bc3852c681c0d948245bd55108dc6407604
NFS - fix recent breakage to NFS error handling.
the code was then messed up a bit by
commit a5c58892b427a2752e3ec44b0aad4ce9221dc63b
NFS: Create a v4-specific fsync function
in v3.6-rc1
and that mess was fixed by
commit 7b281ee026552f10862b617a2a51acf49c829554
NFS: fsync() must exit with an error if page writeback failed
which re-introduced the original problem in v3.6-rc6.
That first patch has been backported to SLES11 so now I'm fixing the bug
again and finding it in mainline again :-)
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2012-12-11 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 22:28 NFS regression - EIO is returned instead of ENOSPC NeilBrown
2012-12-11 22:53 ` NeilBrown [this message]
2012-12-11 23:16 ` Myklebust, Trond
[not found] ` <1355267807.23203.16.camel@lade.trondhjem.org>
2012-12-11 23:20 ` Myklebust, Trond
2012-12-12 0:05 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212095304.368c9708@notabene.brown \
--to=neilb@suse.de \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).