linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Ben Myers <bpm@sgi.com>
Cc: Olga Kornievskaia <aglo@citi.umich.edu>,
	linux-nfs@vger.kernel.org, Jim Rees <rees@umich.edu>
Subject: Re: sunrpc: socket buffer size tuneable
Date: Fri, 25 Jan 2013 15:51:45 -0500	[thread overview]
Message-ID: <20130125205145.GF29596@fieldses.org> (raw)
In-Reply-To: <20130125203521.GE29596@fieldses.org>

On Fri, Jan 25, 2013 at 03:35:21PM -0500, J. Bruce Fields wrote:
> On Fri, Jan 25, 2013 at 03:21:07PM -0500, J. Bruce Fields wrote:
> > 
> > > On Fri, Jan 25, 2013 at 01:29:35PM -0600, Ben Myers wrote:
> > > > Hey Bruce & Jim & Olga,
> > > > 
> > > > On Fri, Jan 25, 2013 at 02:16:20PM -0500, Jim Rees wrote:
> > > > > J. Bruce Fields wrote:
> > > > > 
> > > > >   On Thu, Jan 24, 2013 at 06:59:30PM -0600, Ben Myers wrote:
> > > > >   > At 1020 threads the send buffer size wraps and becomes negative causing
> > > > >   > the nfs server to grind to a halt.  Rather than setting bufsize based
> > > > >   > upon the number of nfsd threads, make the buffer sizes tuneable via
> > > > >   > module parameters.
> > > > >   > 
> > > > >   > Set the buffer sizes in terms of the number of rpcs you want to fit into
> > > > >   > the buffer.
> > > > >   
> > > > >   From private communication, my understanding is that the original
> > > > >   problem here was due to memory pressure forcing the tcp send buffer size
> > > > >   below the size required to hold a single rpc.
> > > > 
> > > > Years ago I did see wrapping of the buffer size when tcp was used with many
> > > > threads.  Today's problem is timeouts on a cluster with a heavy read
> > > > workload... and I seem to remember seeing that the send buffer size was too
> > > > small.
> > > > 
> > > > >   In which case the important variable here is lock_bufsize, as that's
> > > > >   what prevents the buffer size from going too low.
> > > > 
> > > > I tested removing the lock of bufsize and did hit the timeouts, so the overflow
> > > > is starting to look less relevant.  I will test your minimal overflow fix to
> > > > see if this is the case.
> > > 
> > > The minimal overflow fix did not resolve the timeouts.
> > 
> > OK, thanks, that's expected.
> > 
> > > I will test with this to see if it resolves the timeouts:
> > 
> > And I'd expect that to do the job--but at the expense of some tcp
> > bandwidth.  So you end up needing your other module parameters to get
> > the performance back.
> 
> Also, what do you see happening on the server in the problem case--are
> threads blocking in svc_send, or are they dropping replies?

And what exactly is your test?

--b.

  reply	other threads:[~2013-01-25 20:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-25  0:59 sunrpc: socket buffer size tuneable Ben Myers
2013-01-25 18:45 ` J. Bruce Fields
2013-01-25 19:10   ` Ben Myers
2013-01-25 18:57 ` J. Bruce Fields
2013-01-25 19:16   ` Jim Rees
2013-01-25 19:29     ` Ben Myers
2013-01-25 20:21       ` J. Bruce Fields
2013-01-25 20:35         ` Ben Myers
2013-01-25 21:12           ` Myklebust, Trond
2013-01-25 21:21             ` J. Bruce Fields
2013-01-25 21:29               ` Myklebust, Trond
2013-01-25 21:35                 ` J. Bruce Fields
2013-01-25 21:45                   ` Myklebust, Trond
2013-01-25 21:57                     ` J. Bruce Fields
2013-01-25 22:02                       ` Ben Myers
2013-01-25 22:20                       ` Myklebust, Trond
2013-01-25 22:34                         ` J. Bruce Fields
2013-01-25 23:00                           ` Myklebust, Trond
2013-01-25 20:35         ` J. Bruce Fields
2013-01-25 20:51           ` J. Bruce Fields [this message]
2013-01-25 21:13             ` Ben Myers
2013-01-25 21:02           ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130125205145.GF29596@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=aglo@citi.umich.edu \
    --cc=bpm@sgi.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=rees@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).