From: "bfields@fieldses.org" <bfields@fieldses.org>
To: fanchaoting <fanchaoting@cn.fujitsu.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsd: Check the nfsd support version when enable or disable the minorversion
Date: Tue, 29 Jan 2013 13:13:44 -0500 [thread overview]
Message-ID: <20130129181344.GA4209@fieldses.org> (raw)
In-Reply-To: <510247B8.4020207@cn.fujitsu.com>
On Fri, Jan 25, 2013 at 04:52:08PM +0800, fanchaoting wrote:
> when enable or disable the minorversion throw /proc/fs/nfsd/versions,
> it should check the support version. now only nfs4 suppport minorversion.
>
> Signed-off-by: Fan Chaoting <fanchaoting@cn.fujitsu.com>
Apologies, I'd already committed the same fix (and credited you with
reported-by:) before seeing this.--b.
>
> ---
> fs/nfsd/nfsctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 7493428..65889ec 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -534,7 +534,7 @@ static ssize_t __write_versions(struct file *file, char *buf, size_t size)
> else
> num = simple_strtol(vers, &minorp, 0);
> if (*minorp == '.') {
> - if (num < 4)
> + if (num != 4)
> return -EINVAL;
> minor = simple_strtoul(minorp+1, NULL, 0);
> if (minor == 0)
> --
> 1.7.10.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-01-29 18:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 9:58 [PATCH] nfsd: Check the nfsd support version when enable or disable the minorversion fanchaoting
2013-01-23 23:24 ` bfields
2013-01-24 1:22 ` fanchaoting
2013-01-25 8:52 ` fanchaoting
2013-01-29 18:13 ` bfields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129181344.GA4209@fieldses.org \
--to=bfields@fieldses.org \
--cc=fanchaoting@cn.fujitsu.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).