public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Stanislav Kinsbursky <skinsbursky@parallels.com>
Cc: linux-nfs@vger.kernel.org, Trond.Myklebust@netapp.com,
	linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: [RFC PATCH 0/4] SUNRPC: rework cache upcall to avoid NFSd root swapping
Date: Wed, 30 Jan 2013 18:00:52 -0500	[thread overview]
Message-ID: <20130130230052.GB16158@fieldses.org> (raw)
In-Reply-To: <20130115080402.2996.74320.stgit@localhost.localdomain>

On Tue, Jan 15, 2013 at 11:09:23AM +0300, Stanislav Kinsbursky wrote:
> The main idea of this patch set is to call cache request not on kthread
> upcall, but on userspace daemon cache_read call. This fixes the problem with
> gaining of wrong dentry path after calling d_path() in kthread root context
> (svc_export_request() callback), which always work in init root context, but
> containers can work in "root jail" - i.e. have it's own nested root.

Sorry for the delay.  This looks good to me--committing pending some
testing.

What's left now for basic containerized nfsd support?

--b.

> 
> The following series implements...
> 
> ---
> 
> Stanislav Kinsbursky (4):
>       SUNRPC: introduce cache_detail->cache_request callback
>       SUNRPC: remove cache_detail->cache_upcall callback
>       SUNRPC: remove "cache_request" argument in sunrpc_cache_pipe_upcall() function
>       SUNRPC: move cache_detail->cache_request callback call to cache_read()
> 
> 
>  fs/nfs/dns_resolve.c              |    2 +-
>  fs/nfsd/export.c                  |   14 ++----------
>  fs/nfsd/nfs4idmap.c               |   16 ++-----------
>  include/linux/sunrpc/cache.h      |   11 +++------
>  net/sunrpc/auth_gss/svcauth_gss.c |    8 +------
>  net/sunrpc/cache.c                |   44 ++++++++++++++++++++-----------------
>  net/sunrpc/svcauth_unix.c         |   14 ++----------
>  7 files changed, 36 insertions(+), 73 deletions(-)
> 

  parent reply	other threads:[~2013-01-30 23:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15  8:09 [RFC PATCH 0/4] SUNRPC: rework cache upcall to avoid NFSd root swapping Stanislav Kinsbursky
2013-01-15  8:09 ` [PATCH 1/4] SUNRPC: introduce cache_detail->cache_request callback Stanislav Kinsbursky
2013-01-15  8:09 ` [PATCH 2/4] SUNRPC: remove cache_detail->cache_upcall callback Stanislav Kinsbursky
2013-02-04 16:50   ` Jeff Layton
2013-02-04 17:15     ` J. Bruce Fields
2013-02-05  5:37     ` Stanislav Kinsbursky
2013-01-15  8:09 ` [PATCH 3/4] SUNRPC: remove "cache_request" argument in sunrpc_cache_pipe_upcall() function Stanislav Kinsbursky
2013-01-15  8:09 ` [PATCH 4/4] SUNRPC: move cache_detail->cache_request callback call to cache_read() Stanislav Kinsbursky
2013-01-30 23:00 ` J. Bruce Fields [this message]
2013-01-31  5:15   ` [RFC PATCH 0/4] SUNRPC: rework cache upcall to avoid NFSd root swapping Stanislav Kinsbursky
2013-02-04 10:22   ` Stanislav Kinsbursky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130130230052.GB16158@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=Trond.Myklebust@netapp.com \
    --cc=devel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=skinsbursky@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox