Linux NFS development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Jeff Layton <jlayton@redhat.com>,
	"chuck.lever@oracle.com" <chuck.lever@oracle.com>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] sunrpc: move address copy/cmp/convert routines and prototypes from clnt.h to addr.h
Date: Mon, 4 Feb 2013 11:18:25 -0500	[thread overview]
Message-ID: <20130204161825.GF815@fieldses.org> (raw)
In-Reply-To: <4FA345DA4F4AE44899BD2B03EEEC2FA91835C73B@SACEXCMBX04-PRD.hq.netapp.com>

On Mon, Feb 04, 2013 at 04:15:43PM +0000, Myklebust, Trond wrote:
> On Mon, 2013-02-04 at 11:09 -0500, J. Bruce Fields wrote:
> > On Mon, Feb 04, 2013 at 10:23:51AM -0500, Jeff Layton wrote:
> > > These routines are used by server and client code, so having them in a
> > > separate header would be best.
> > 
> > I'll apply this and the scope id patch if it gets Trond's ACK.
> > 
> > (Or they have my ACK if Trond wants to take them.)
> 
> Feel free to take them through the nfsd tree.
> 
> Acked-by: Trond Myklebust <Trond.Myklebust@netapp.com>

Thanks.  I needed to add the following.

We should make sure none of the other files including clnt.h might also
need one of these.

--b.

commit a487a5ec9e2f37472097a3ff3535c87c6af334e9
Author: J. Bruce Fields <bfields@redhat.com>
Date:   Mon Feb 4 11:13:24 2013 -0500

    foldme

diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c
index e761ee9..255ae32 100644
--- a/fs/nfsd/fault_inject.c
+++ b/fs/nfsd/fault_inject.c
@@ -10,6 +10,7 @@
 #include <linux/module.h>
 #include <linux/nsproxy.h>
 #include <linux/sunrpc/clnt.h>
+#include <linux/sunrpc/addr.h>
 #include <asm/uaccess.h>
 
 #include "state.h"

  reply	other threads:[~2013-02-04 16:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04 15:23 [PATCH] sunrpc: move address copy/cmp/convert routines and prototypes from clnt.h to addr.h Jeff Layton
2013-02-04 16:09 ` J. Bruce Fields
2013-02-04 16:15   ` Myklebust, Trond
2013-02-04 16:18     ` J. Bruce Fields [this message]
2013-02-04 17:01       ` J. Bruce Fields
2013-02-04 17:50 ` [PATCH v2] " Jeff Layton
2013-02-04 18:10   ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130204161825.GF815@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=Trond.Myklebust@netapp.com \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox