From: "J. Bruce Fields" <bfields@fieldses.org>
To: Steve Dickson <SteveD@redhat.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
Linux NFS list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 00/14] lnfs: 3.8-rc7 release
Date: Wed, 20 Feb 2013 10:59:33 -0500 [thread overview]
Message-ID: <20130220155933.GI14606@fieldses.org> (raw)
In-Reply-To: <5124F1EA.2090902@RedHat.com>
On Wed, Feb 20, 2013 at 10:55:22AM -0500, Steve Dickson wrote:
> Trimming the cc list to just Linux NFS list since I'm
> sure they will not care about this part of the discussion.
> I'll add them back on my next release...
>
> On 19/02/13 15:56, J. Bruce Fields wrote:
> > On Tue, Feb 19, 2013 at 10:40:47AM -0500, Steve Dickson wrote:
> >> On 19/02/13 10:18, J. Bruce Fields wrote:
> >>> On Tue, Feb 19, 2013 at 10:10:15AM -0500, Steve Dickson wrote:
> >>>>
> >>>>
> >>>> On 18/02/13 14:58, J. Bruce Fields wrote:
> >>>>> On Mon, Feb 18, 2013 at 01:47:42PM -0500, Steve Dickson wrote:
> >>>>>>> From: Steve Dickson <steved@redhat.com>
> >>>>>>>
> >>>>>>> Here is the next release of the Label NFS patches, forward
> >>>>>>> ported to linux-3.8-rc7
> >>>>>>>
> >>>>>>> I believe I've incorporated all code review that were made
> >>>>>>> from the last release,
> >>>>> Except I think this doesn't turn on minor version 2?
> >>>> Are you saying we need a -o v4.2 mount option to enable this feature?
> >>> Yes. And the client needs to send requests with minor version 2, and
> >>> server needs to accept such requests.
> >> Boy this puts a damper on the party.... ;-)
> >
> > I'm hoping it's not that much work: we already have two minor versions
> > (0 and 1), in theory adding a third should be pretty straightforward.
> >
> > Labeled NFS will be our only 4.2 feature for now, so there's nothing
> > else to do other than turn on support for the new minor version number.
> >
> > I think so?
> On the client the actual change is very straightforward. Simply added
> another case to the switch in nfs_parse_version_string() and set the
> minorversion to 2
>
> case Opt_vers_4_2:
> mnt->version = 4;
> mnt->minorversion = 2;
> break;
>
> But my question is what type of ramification well there be bumping
> minorversion from 1 to 2? I bet servers are not going to like this
> too much... ;-)
If they support labeld NFS, they have to support minor version 2.
> and not to mention all the xdr and callback routines
> that look at minorversion... a bit worrisome...
>
> Speaking of servers... Do you think its about time to rpc.nfsd the
> ability to enable 4.x versions?
echo "+4.2" >/proc/fs/nfsd/versions
--b.
next prev parent reply other threads:[~2013-02-20 15:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 18:47 [PATCH 00/14] lnfs: 3.8-rc7 release Steve Dickson
2013-02-18 18:47 ` [PATCH 01/14] Security: Add hook to calculate context based on a negative dentry Steve Dickson
2013-02-18 18:47 ` [PATCH 02/14] Security: Add Hook to test if the particular xattr is part of a MAC model Steve Dickson
2013-02-18 18:47 ` [PATCH 03/14] LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount data Steve Dickson
2013-02-18 18:47 ` [PATCH 04/14] SELinux: Add new labeling type native labels Steve Dickson
2013-02-18 18:47 ` [PATCH 05/14] NFSv4: Add label recommended attribute and NFSv4 flags Steve Dickson
2013-02-18 18:47 ` [PATCH 06/14] NFSv4: Introduce new label structure Steve Dickson
2013-02-18 18:47 ` [PATCH 07/14] NFSv4: Extend fattr bitmaps to support all 3 words Steve Dickson
2013-02-18 18:47 ` [PATCH 08/14] NFS:Add labels to client function prototypes Steve Dickson
2013-02-18 18:47 ` [PATCH 09/14] NFS: Add label lifecycle management Steve Dickson
2013-02-18 18:47 ` [PATCH 10/14] NFS: Client implementation of Labeled-NFS Steve Dickson
2013-02-18 18:47 ` [PATCH 11/14] NFS: Extend NFS xattr handlers to accept the security namespace Steve Dickson
2013-02-18 18:47 ` [PATCH 12/14] Kconfig: Add Kconfig entry for Labeled NFS V4 client Steve Dickson
2013-02-18 18:47 ` [PATCH 13/14] NFSD: Server implementation of MAC Labeling Steve Dickson
2013-02-18 18:47 ` [PATCH 14/14] Kconfig: Add Kconfig entry for Labeled NFS V4 server Steve Dickson
2013-02-18 19:58 ` [PATCH 00/14] lnfs: 3.8-rc7 release J. Bruce Fields
2013-02-18 21:02 ` J. Bruce Fields
2013-02-19 15:11 ` Steve Dickson
2013-02-19 15:10 ` Steve Dickson
2013-02-19 15:18 ` J. Bruce Fields
2013-02-19 15:40 ` Steve Dickson
2013-02-19 20:20 ` Steve Dickson
2013-02-19 20:24 ` J. Bruce Fields
2013-02-19 20:56 ` J. Bruce Fields
2013-02-20 15:55 ` Steve Dickson
2013-02-20 15:59 ` J. Bruce Fields [this message]
2013-02-20 16:22 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220155933.GI14606@fieldses.org \
--to=bfields@fieldses.org \
--cc=SteveD@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox