From: "J. Bruce Fields" <bfields@fieldses.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
"David S. Miller" <davem@davemloft.net>,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] sunrpc: drop "select NETVM"
Date: Sat, 9 Mar 2013 12:51:18 -0500 [thread overview]
Message-ID: <20130309175118.GJ31448@fieldses.org> (raw)
In-Reply-To: <1362844951.3137.3.camel@x61.thuisdomein>
ACK.
On Sat, Mar 09, 2013 at 05:02:31PM +0100, Paul Bolle wrote:
> The Kconfig entry for SUNRPC_SWAP selects NETVM. That select statement
> was added in commit a564b8f0398636ba30b07c0eaebdef7ff7837249 ("nfs:
> enable swap on NFS").
Cc'ing Mel Gorman just in case there was something else going on there.
--b.
> But there's no Kconfig symbol NETVM. It apparently
> was only in used in development versions of the swap over nfs
> functionality but never entered mainline. Anyhow, it is a nop and can
> safely be dropped.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> net/sunrpc/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/sunrpc/Kconfig b/net/sunrpc/Kconfig
> index 516fe2c..262caf0 100644
> --- a/net/sunrpc/Kconfig
> +++ b/net/sunrpc/Kconfig
> @@ -24,7 +24,6 @@ config SUNRPC_XPRT_RDMA
> config SUNRPC_SWAP
> bool
> depends on SUNRPC
> - select NETVM
>
> config RPCSEC_GSS_KRB5
> tristate "Secure RPC: Kerberos V mechanism"
> --
> 1.7.11.7
>
next prev parent reply other threads:[~2013-03-09 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 16:02 [PATCH] sunrpc: drop "select NETVM" Paul Bolle
2013-03-09 17:51 ` J. Bruce Fields [this message]
2013-03-13 10:08 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130309175118.GJ31448@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).