From: Al Viro <viro@ZenIV.linux.org.uk>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Toralf F??rster <toralf.foerster@gmx.de>,
Linux NFS mailing list <linux-nfs@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: kernel 3.8.4 : kernel BUG at fs/locks.c:2093! part #2
Date: Tue, 26 Mar 2013 17:37:47 +0000 [thread overview]
Message-ID: <20130326173747.GV21522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130326144640.GB3353@fieldses.org>
On Tue, Mar 26, 2013 at 10:46:40AM -0400, J. Bruce Fields wrote:
> > fs/locks.c:2093 says that we did the final fput of a file that still had
> > posix locks held on it.
> >
> > I can't see how that would happen, but admittedly the nfsd4 code here is
> > much too complicated for its own good.
> >
> > If it were possible it would be useful to know what lead up to this. A
> > network trace (tcpdump -s0 -wtmp.pcap, then send me tmp.pcap) would be
> > useful for that, but I fear it's probably too huge by the time you hit
> > the bug.
> >
> > (The following warning ("rcu_sched self-detected stall") looks like the
> > result of BUGing while holding file_lock_lock. That BUG should probably
> > be downgraded to a WARN_ON_ONCE.)
>
> Can you run with test patches?
>
> This just makes nfsd's fput calls synchronous so that we see in the
> backtrace who called them.
>
> (But assuming it does turn out to be one of these callers, we may then
> need some more printk's in the nfsd code...).
Might also be a good idea to dump the offending struct file_lock, while
we are at it...
next prev parent reply other threads:[~2013-03-26 17:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 17:02 kernel 3.8.4 : kernel BUG at fs/locks.c:2093! part #2 Toralf Förster
2013-03-25 22:01 ` J. Bruce Fields
2013-03-26 14:46 ` J. Bruce Fields
2013-03-26 17:37 ` Al Viro [this message]
2013-03-26 17:46 ` Toralf Förster
2013-03-26 18:17 ` J. Bruce Fields
2013-03-27 17:20 ` Toralf Förster
2013-03-27 17:46 ` J. Bruce Fields
2013-03-27 21:35 ` Toralf Förster
2013-03-27 21:57 ` J. Bruce Fields
2013-03-29 18:43 ` J. Bruce Fields
2013-04-01 20:26 ` Toralf Förster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326173747.GV21522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).