From: "J. Bruce Fields" <bfields@fieldses.org>
To: James Morris <james.l.morris@oracle.com>
Cc: Serge Hallyn <serge.hallyn@canonical.com>,
linux-security-module@vger.kernel.org, linux-nfs@vger.kernel.org,
"David P. Quigley" <dpquigl@tycho.nsa.gov>,
Steve Dickson <SteveD@redhat.com>
Subject: [PATCH] security: clarify cap_inode_getsecctx description
Date: Thu, 9 May 2013 11:41:04 -0400 [thread overview]
Message-ID: <20130509154104.GD9316@fieldses.org> (raw)
In-Reply-To: <20130509151333.GA2211@tp>
From: "J. Bruce Fields" <bfields@redhat.com>
Make it clear that cap_inode_getsecctx shouldn't return success without
filling in the context data.
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
include/linux/security.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/security.h b/include/linux/security.h
index 4686491..40560f4 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -1392,7 +1392,8 @@ static inline void security_free_mnt_opts(struct security_mnt_opts *opts)
* @ctxlen contains the length of @ctx.
*
* @inode_getsecctx:
- * Returns a string containing all relevant security context information
+ * On success, returns 0 and fills out @ctx and @ctxlen with the security
+ * context for the given @inode.
*
* @inode we wish to get the security context of.
* @ctx is a pointer in which to place the allocated security context.
--
1.7.9.5
next prev parent reply other threads:[~2013-05-09 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 1:43 [PATCH] security: cap_inode_getsecctx returning garbage J. Bruce Fields
2013-05-09 5:49 ` Serge Hallyn
2013-05-09 14:08 ` J. Bruce Fields
2013-05-09 15:13 ` Serge Hallyn
2013-05-09 15:41 ` J. Bruce Fields [this message]
2013-05-12 11:37 ` [PATCH] security: clarify cap_inode_getsecctx description James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509154104.GD9316@fieldses.org \
--to=bfields@fieldses.org \
--cc=SteveD@redhat.com \
--cc=dpquigl@tycho.nsa.gov \
--cc=james.l.morris@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox