From: Neil Brown <neilb@suse.de>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH 1/3] krb5_utils: remove redundant array size.
Date: Mon, 03 Jun 2013 11:00:21 +1000 [thread overview]
Message-ID: <20130603010021.20080.24416.stgit@notabene.brown> (raw)
In-Reply-To: <20130603005219.20080.1927.stgit@notabene.brown>
When initialising an array there is no need to specify the size as the
size is taken from the initialiser. Having the size there means that
any change to the initialiser needs to change the size to and so is
error-prone.
So just remove the size.
Signed-off-by: NeilBrown <neilb@suse.de>
---
utils/gssd/krb5_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c
index 6275dd8..9ef80f0 100644
--- a/utils/gssd/krb5_util.c
+++ b/utils/gssd/krb5_util.c
@@ -1236,7 +1236,7 @@ gssd_refresh_krb5_machine_credential(char *hostname,
krb5_keytab kt = NULL;;
int retval = 0;
char *k5err = NULL;
- const char *svcnames[5] = { "$", "root", "nfs", "host", NULL };
+ const char *svcnames[] = { "$", "root", "nfs", "host", NULL };
/*
* If a specific service name was specified, use it.
next prev parent reply other threads:[~2013-06-03 1:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 1:00 [PATCH 0/3] Various gssd fixes including machine-credential issue Neil Brown
2013-06-03 1:00 ` Neil Brown [this message]
2013-07-01 16:05 ` [PATCH 1/3] krb5_utils: remove redundant array size Steve Dickson
2013-06-03 1:00 ` [PATCH 3/3] gssd: add -N option to use root credentials as machine credentials Neil Brown
2013-07-01 16:23 ` Steve Dickson
2013-07-01 21:35 ` NeilBrown
2013-06-03 1:00 ` [PATCH 2/3] krb5_util: don't give up on machine credential if hostname not available Neil Brown
2013-07-01 16:22 ` Steve Dickson
2013-07-01 21:56 ` NeilBrown
2013-07-02 12:29 ` Steve Dickson
2013-07-02 12:29 ` Steve Dickson
2013-06-03 2:01 ` [PATCH 0/3] Various gssd fixes including machine-credential issue Chuck Lever
2013-06-03 2:23 ` NeilBrown
2013-06-03 2:45 ` Chuck Lever
2013-06-03 3:01 ` NeilBrown
2013-06-03 4:32 ` Chuck Lever
2013-06-03 23:30 ` NeilBrown
2013-06-04 1:13 ` Chuck Lever
2013-06-04 19:16 ` Chuck Lever
2013-06-05 1:26 ` NeilBrown
2013-06-05 15:37 ` Chuck Lever
2013-06-05 17:14 ` Chuck Lever
2013-06-05 23:53 ` NeilBrown
2013-06-05 23:43 ` NeilBrown
2013-06-12 6:12 ` NeilBrown
2013-06-12 16:01 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603010021.20080.24416.stgit@notabene.brown \
--to=neilb@suse.de \
--cc=SteveD@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).