From: Jeff Layton <jlayton@redhat.com>
To: Malahal Naineni <malahal@us.ibm.com>
Cc: linux-nfs@vger.kernel.org, Trond.Myklebust@netapp.com,
Bryan Schumaker <bjschuma@netapp.com>
Subject: Re: corruption due to loss of lock
Date: Thu, 11 Jul 2013 07:13:46 -0400 [thread overview]
Message-ID: <20130711071346.03b946bd@corrin.poochiereds.net> (raw)
In-Reply-To: <20130613184737.GA25713@us.ibm.com>
On Thu, 13 Jun 2013 13:47:37 -0500
Malahal Naineni <malahal@us.ibm.com> wrote:
> Hi Trond,
>
> I saw Bryan's patches here https://patchwork.kernel.org/patch/987402/
> that fix issues after loss of a lock. What is the status on this patch
> set? Do they need more work? We have an application that uses range
> locks on a file. Two threads from two different clients end up writing
> to the same a file due to this bug after a lease expiry from a client.
>
> Regards, Malahal.
(cc'ing Bryan since he did the original set)
Yeah, this set would be a nice thing to have. A couple of comments:
- I still think it would be best to make SIGLOST its own signal, but as
Bryan points out, it would need to be larger than SIGRTMAX. I'm
not sure that's possible on all arches with the way the RT signals
were done. It's probably worth investigating that though before
settling on SIGIO since it would be hard to change that retroactively.
- This is not really a v4.1 specific thing. It should also be done for
v4.0 and v2/3, though the latter two really need to be done within
lockd.
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2013-07-11 11:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 18:47 corruption due to loss of lock Malahal Naineni
2013-07-11 11:13 ` Jeff Layton [this message]
2013-07-11 14:12 ` Malahal Naineni
2013-07-11 14:19 ` Myklebust, Trond
2013-07-11 14:28 ` Jeff Layton
2013-07-11 14:33 ` Myklebust, Trond
2013-07-11 15:20 ` Jeff Layton
2013-07-11 15:39 ` Malahal Naineni
2013-07-11 16:28 ` Myklebust, Trond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711071346.03b946bd@corrin.poochiereds.net \
--to=jlayton@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bjschuma@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=malahal@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).