From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Nick Piggin <npiggin@kernel.dk>
Subject: Re: [PATCH 2/3] dcache: Don't set DISCONNECTED on "pseudo filesystem" dentries
Date: Fri, 6 Sep 2013 10:03:39 -0700 [thread overview]
Message-ID: <20130906170339.GB6460@infradead.org> (raw)
In-Reply-To: <1378482230-16312-2-git-send-email-bfields@redhat.com>
On Fri, Sep 06, 2013 at 11:43:49AM -0400, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
>
> I can't for the life of me see any reason why anyone would care whether
> a dentry that is never hooked into the dentry cache would need
> DCACHE_DISCONNECTED set.
__d_shrink did before your PATCH 1/3.
With that fixed your patch looks fine.
> +/*
> + * For filesystems that do not actually use the dentry cache at all, and
> + * only ever deal in IS_ROOT() dentries:
> + */
If you document the function it really should be a kerneldoc comment.
Also the description, while technically correct, isn't all that useful.
It need an explanation why the filesystem is fine with unhashed
dentries, and the reason is that it never performs any lookups as it
pins the dentries in memory.
next prev parent reply other threads:[~2013-09-06 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 15:43 [PATCH 1/3] dcache: use IS_ROOT to decide where dentry is hashed J. Bruce Fields
2013-09-06 15:43 ` [PATCH 2/3] dcache: Don't set DISCONNECTED on "pseudo filesystem" dentries J. Bruce Fields
2013-09-06 17:03 ` Christoph Hellwig [this message]
2013-09-06 19:29 ` J. Bruce Fields
2013-09-06 15:43 ` [PATCH 3/3] dcache: don't clear DCACHE_DISCONNECTED too early J. Bruce Fields
2013-09-06 17:00 ` [PATCH 1/3] dcache: use IS_ROOT to decide where dentry is hashed Christoph Hellwig
2013-09-06 19:03 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906170339.GB6460@infradead.org \
--to=hch@infradead.org \
--cc=bfields@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).