From: Christoph Hellwig <hch@infradead.org>
To: Benny Halevy <bhalevy@primarydata.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/4] SQUASHME: pnfsd: no need for find_file in layout commit/return
Date: Sun, 6 Oct 2013 08:30:46 -0700 [thread overview]
Message-ID: <20131006153046.GB8801@infradead.org> (raw)
In-Reply-To: <1381045472-30717-1-git-send-email-bhalevy@primarydata.com>
On Sun, Oct 06, 2013 at 10:44:32AM +0300, Benny Halevy wrote:
> the nfs4_file can be found via the layout stateid.
Oh, here we go. Really should be folded into the previous one to make
sense.
> /* Is this the first use of this layout ? */
> if (stid->sc_type != NFS4_LAYOUT_STID) {
> + status = nfserr_bad_stateid;
> + goto out;
> } else {
Given that you already have a goto out here there is no need for the
else clause.
next prev parent reply other threads:[~2013-10-06 15:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 7:40 [PATCH 0/4] pnfsd: refactor nfs4_process_layout_stateid Benny Halevy
2013-10-06 7:44 ` [PATCH 1/4] SQUASHME: fix lo_destroy_list nested definition Benny Halevy
2013-10-06 7:44 ` [PATCH 2/4] SQUASHME: pnfsd: nfs4_find_create_layout_stateid Benny Halevy
2013-10-06 15:29 ` Christoph Hellwig
2013-10-07 15:03 ` Benny Halevy
2013-10-07 15:45 ` [PATCH v2 " Benny Halevy
2013-10-06 7:44 ` [PATCH 3/4] SQUASHME: pnfsd: no need for find_file in layout commit/return Benny Halevy
2013-10-06 15:30 ` Christoph Hellwig [this message]
2013-10-07 15:50 ` [PATCH v2 " Benny Halevy
2013-10-06 7:44 ` [PATCH 4/4] SQUASHME: pnfsd: fixup error code for layout_commit Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131006153046.GB8801@infradead.org \
--to=hch@infradead.org \
--cc=bhalevy@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).