From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] st_destroy_session: remove invalid testcase
Date: Mon, 7 Oct 2013 11:37:55 -0400 [thread overview]
Message-ID: <20131007153755.GG18051@fieldses.org> (raw)
In-Reply-To: <1380918492-8413-1-git-send-email-tigran.mkrtchyan@desy.de>
On Fri, Oct 04, 2013 at 10:28:12PM +0200, Tigran Mkrtchyan wrote:
> we cant expect NFS4ERR_NOT_ONLY_OP if spec
> enforces NFS4ERR_OP_NOT_IN_SESSION
I guess we could just add that to the list of allowable error returns,
but... yeah, OK, let's just remove that test. Applied.
--b.
>
> Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
> ---
> nfs4.1/server41tests/st_destroy_session.py | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/nfs4.1/server41tests/st_destroy_session.py b/nfs4.1/server41tests/st_destroy_session.py
> index 1feb671..f4f0762 100644
> --- a/nfs4.1/server41tests/st_destroy_session.py
> +++ b/nfs4.1/server41tests/st_destroy_session.py
> @@ -164,6 +164,3 @@ def testDestoryNotSoleOps(t, env):
> sid = sess1.sessionid
> res = c.c.compound([op.destroy_session(sess1.sessionid), op.putrootfh()])
> check(res, NFS4ERR_NOT_ONLY_OP)
> -
> - res = c.c.compound([op.putrootfh(), op.destroy_session(sess1.sessionid)])
> - check(res, NFS4ERR_NOT_ONLY_OP)
> --
> 1.8.3.1
>
prev parent reply other threads:[~2013-10-07 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 20:28 [PATCH] st_destroy_session: remove invalid testcase Tigran Mkrtchyan
2013-10-07 15:37 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131007153755.GG18051@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tigran.mkrtchyan@desy.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).