From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Trond Myklebust <trond@netapp.com>,
linux-nfs@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] nfs: use IS_ROOT not DCACHE_DISCONNECTED
Date: Wed, 16 Oct 2013 00:11:10 -0700 [thread overview]
Message-ID: <20131016071110.GA27799@infradead.org> (raw)
In-Reply-To: <20131015210316.GA11616@fieldses.org>
On Tue, Oct 15, 2013 at 05:03:16PM -0400, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
>
> This check was added by Al Viro with
> d9e80b7de91db05c1c4d2e5ebbfd70b3b3ba0e0f "nfs d_revalidate() is too
> trigger-happy with d_drop()", with the explanation that we don't want to
> remove the root of a disconnected tree, which will still be included on
> the s_anon list.
>
> But DCACHE_DISCONNECTED does *not* actually identify dentries that are
> disconnected from the dentry tree or hashed on s_anon. IS_ROOT() is the
> way to do that.
>
> Also add a comment from Al's commit to remind us why this check is
> there.
Looks good.
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2013-10-16 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 21:03 [PATCH] nfs: use IS_ROOT not DCACHE_DISCONNECTED J. Bruce Fields
2013-10-16 7:11 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016071110.GA27799@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond@netapp.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).