Re: Different sequence of "exportfs" produce different effects on nfs client mounts

["J. Bruce Fields" <bfields@fieldses.org>]

On Thu, Oct 17, 2013 at 09:14:02AM -0400, Chuck Lever wrote:
> Hi-
> 
> 281         if (ident[0] == '\0')
> 282                 return MCL_ANONYMOUS;
> 283         if (ident[0] == '@') {
> 284 #ifndef HAVE_INNETGR
> 285                 xlog(L_WARNING, "netgroup support not compiled in");
> 286 #endif
> 287                 return MCL_NETGROUP;
> 288         }
> 289         for (sp = ident; *sp; sp++) {
> 290                 if (*sp == '*' || *sp == '?' || *sp == '[')
> 291                         return MCL_WILDCARD;
> 292                 if (*sp == '/')
> 293                         return MCL_SUBNETWORK;
> 294                 if (*sp == '\\' && sp[1])
> 295                         sp++;
> 296         }
> 
> is still in play today.  The "host_pton()" code you posted was added by commit 502edf1d just after this paragraph.  But here is what that commit replaced.
> 
> -       /* check for N.N.N.N */
> -       sp = ident;
> -       if(!isdigit(*sp) || strtoul(sp, &sp, 10) > 255 || *sp != '.') return MCL_FQDN;
> -       sp++; if(!isdigit(*sp) || strtoul(sp, &sp, 10) > 255 || *sp != '.') return MCL_F
> -       sp++; if(!isdigit(*sp) || strtoul(sp, &sp, 10) > 255 || *sp != '.') return MCL_F
> -       sp++; if(!isdigit(*sp) || strtoul(sp, &sp, 10) > 255 || *sp != '\0') return MCL_
> -       /* we lie here a bit. but technically N.N.N.N == N.N.N.N/32 :) */
> -       return MCL_SUBNETWORK;
> +
> +       /*
> +        * Treat unadorned IP addresses as MCL_SUBNETWORK.
> +        * Everything else is MCL_FQDN.
> +        */
> +       ai = host_pton(ident);
> +       if (ai != NULL) {
> +               freeaddrinfo(ai);
> +               return MCL_SUBNETWORK;
> +       }
> +
> +       return MCL_FQDN;
>  }
> 
> The replaced logic also treats IP addresses as MCL_SUBNETWORK.  That's from commit 54669c98 in 2005.  Neil, do you remember why this semantic change was made?

Um, sorry Neil, looks like Chuck and I were both searching the git logs
at the same time!

--b.