linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 10/21] NFS: Re-use exit code in nfs4_async_handle_error()
Date: Thu, 17 Oct 2013 14:13:07 -0400	[thread overview]
Message-ID: <20131017181307.1073.97554.stgit@nfsvm18.us.oracle.com> (raw)
In-Reply-To: <20131017180630.1073.18400.stgit@nfsvm18.us.oracle.com>

Clean up.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 fs/nfs/nfs4proc.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index f507e54..297bdd0 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -4757,19 +4757,15 @@ nfs4_async_handle_error(struct rpc_task *task, const struct nfs_server *server,
 			dprintk("%s ERROR %d, Reset session\n", __func__,
 				task->tk_status);
 			nfs4_schedule_session_recovery(clp->cl_session, task->tk_status);
-			task->tk_status = 0;
-			return -EAGAIN;
+			goto restart_call;
 #endif /* CONFIG_NFS_V4_1 */
 		case -NFS4ERR_DELAY:
 			nfs_inc_server_stats(server, NFSIOS_DELAY);
 		case -NFS4ERR_GRACE:
 			rpc_delay(task, NFS4_POLL_RETRY_MAX);
-			task->tk_status = 0;
-			return -EAGAIN;
 		case -NFS4ERR_RETRY_UNCACHED_REP:
 		case -NFS4ERR_OLD_STATEID:
-			task->tk_status = 0;
-			return -EAGAIN;
+			goto restart_call;
 	}
 	task->tk_status = nfs4_map_errors(task->tk_status);
 	return 0;
@@ -4780,6 +4776,7 @@ wait_on_recovery:
 	rpc_sleep_on(&clp->cl_rpcwaitq, task, NULL);
 	if (test_bit(NFS4CLNT_MANAGER_RUNNING, &clp->cl_state) == 0)
 		rpc_wake_up_queued_task(&clp->cl_rpcwaitq, task);
+restart_call:
 	task->tk_status = 0;
 	return -EAGAIN;
 }


  parent reply	other threads:[~2013-10-17 18:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17 18:12 [PATCH 00/21] Basic NFSv4 migration support Chuck Lever
2013-10-17 18:12 ` [PATCH 01/21] SUNRPC: Modify synopsis of rpc_client_register() Chuck Lever
2013-10-17 18:12 ` [PATCH 02/21] SUNRPC: Add a helper to switch the transport of an rpc_clnt Chuck Lever
2013-10-17 18:12 ` [PATCH 03/21] NFS: Add nfs4_update_server Chuck Lever
2013-10-17 18:12 ` [PATCH 04/21] NFS: Add functions to swap transports during migration recovery Chuck Lever
2013-10-17 18:12 ` [PATCH 05/21] NFS: Introduce a vector of migration recovery ops Chuck Lever
2013-10-17 18:12 ` [PATCH 06/21] NFS: Export _nfs_display_fhandle() Chuck Lever
2013-10-17 18:12 ` [PATCH 07/21] NFS: Add method to retrieve fs_locations during migration recovery Chuck Lever
2013-10-17 18:12 ` [PATCH 08/21] NFS: Add a super_block backpointer to the nfs_server struct Chuck Lever
2013-10-17 18:13 ` [PATCH 09/21] NFS: Add basic migration support to state manager thread Chuck Lever
2013-10-17 18:13 ` Chuck Lever [this message]
2013-10-17 18:13 ` [PATCH 11/21] NFS: Rename "stateid_invalid" label Chuck Lever
2013-10-17 18:13 ` [PATCH 12/21] NFS: Add migration recovery callouts in nfs4proc.c Chuck Lever
2013-10-17 18:13 ` [PATCH 13/21] NFS: Handle NFS4ERR_MOVED during delegation recall Chuck Lever
2013-10-17 18:13 ` [PATCH 14/21] NFS: Add method to detect whether an FSID is still on the server Chuck Lever
2013-10-17 18:13 ` [PATCH 15/21] NFS: Support NFS4ERR_LEASE_MOVED recovery in state manager Chuck Lever
2013-10-17 18:13 ` [PATCH 16/21] NFS: Implement support for NFS4ERR_LEASE_MOVED Chuck Lever
2013-10-17 18:13 ` [PATCH 17/21] NFS: Migration support for RELEASE_LOCKOWNER Chuck Lever
2013-10-17 18:13 ` [PATCH 18/21] NFS: Handle NFS4ERR_LEASE_MOVED during async RENEW Chuck Lever
2013-10-17 18:13 ` [PATCH 19/21] NFS: Handle SEQ4_STATUS_LEASE_MOVED Chuck Lever
2013-10-17 18:14 ` [PATCH 20/21] NFS: Set EXCHGID4_FLAG_SUPP_MOVED_MIGR Chuck Lever
2013-10-17 18:14 ` [PATCH 21/21] NFS: Fix possible endless state recovery wait Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131017181307.1073.97554.stgit@nfsvm18.us.oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).