linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jim Rees <rees@umich.edu>
To: Robert Schiele <rschiele@gmail.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] fix race condition for parallel startup of statd
Date: Thu, 31 Oct 2013 09:35:12 -0400	[thread overview]
Message-ID: <20131031133512.GA12550@umich.edu> (raw)
In-Reply-To: <20131031055435.GA27362@ulegcprs1.emea.nsn-net.net>

Robert Schiele wrote:

  @@ -788,6 +794,11 @@ int start_statd(void)
   			}
   			if (nfs_probe_statd())
   				return 1;
  +			while (cnt--) {
  +				nanosleep(&ts, NULL);
  +				if (nfs_probe_statd())
  +					return 1;
  +			}
   		}
   	}
   #endif

Shouldn't this be something like:

			while (cnt--) {
				if (nfs_probe_statd())
					return 1;
				if (nanosleep(&ts, NULL) < 0)
					break;
			}

?

  reply	other threads:[~2013-10-31 13:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-31  5:54 [PATCH] fix race condition for parallel startup of statd Robert Schiele
2013-10-31 13:35 ` Jim Rees [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-11-04  6:52 Robert Schiele

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131031133512.GA12550@umich.edu \
    --to=rees@umich.edu \
    --cc=linux-nfs@vger.kernel.org \
    --cc=rschiele@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).