linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Bruce Fields <bfields@fieldses.org>,
	"Schumaker, Bryan" <Bryan.Schumaker@netapp.com>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 3/4] NFSD: Add WRITE_PLUS support for hole punches
Date: Sat, 2 Nov 2013 08:07:38 -0700	[thread overview]
Message-ID: <20131102150738.GA21133@infradead.org> (raw)
In-Reply-To: <38D14516-BAA4-45BB-8054-ED05AEC22C8F@netapp.com>

On Sat, Nov 02, 2013 at 03:02:29PM +0000, Myklebust, Trond wrote:
> COMMIT has always had a metadata part to it, though. It guarantees stability of the ctime/mime and change attributes in addition to the file size and data.
> 
> IOW: it really is more akin to fsync() than to fdatasync().

That's fine, but so far it wasn't used for any purely metadata
operation.  E.g. if we allow it for a preallocation we should also
allow it for updating the size put the current file size.

And diverting from the spec to your implementation: we'd need a lot more
generic infrastructure to deal with unstable random non-data operations.

  reply	other threads:[~2013-11-02 15:07 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-28 14:57 [PATCH 0/4] NFSD: Add support for WRITE_PLUS and SEEK Anna Schumaker
2013-10-28 14:57 ` [PATCH 1/4] NFSD: Update error codes Anna Schumaker
2013-10-28 14:57 ` [PATCH 2/4] NFSD: Create nfs v4.2 decode ops Anna Schumaker
2013-10-28 20:54   ` J. Bruce Fields
2013-10-28 20:59     ` Myklebust, Trond
2013-10-28 21:11       ` J. Bruce Fields
2013-10-29 12:43         ` Anna Schumaker
2013-10-29 13:33           ` J. Bruce Fields
2013-10-28 14:57 ` [PATCH 3/4] NFSD: Add WRITE_PLUS support for hole punches Anna Schumaker
2013-10-28 21:40   ` J. Bruce Fields
2013-10-29 12:49     ` Anna Schumaker
2013-10-29 13:34       ` J. Bruce Fields
2013-10-29 12:50     ` Anna Schumaker
2013-10-29 13:06       ` J. Bruce Fields
2013-10-29 13:11         ` Anna Schumaker
2013-10-29 13:23         ` Myklebust, Trond
2013-10-29 13:28           ` Anna Schumaker
2013-10-29 13:32           ` Dr Fields James Bruce
2013-11-02 13:54         ` Christoph Hellwig
2013-11-02 14:44           ` J. Bruce Fields
2013-11-02 14:51             ` Christoph Hellwig
2013-11-02 15:02               ` Myklebust, Trond
2013-11-02 15:07                 ` Christoph Hellwig [this message]
2013-11-02 15:20     ` Christoph Hellwig
2013-11-02 13:52   ` Christoph Hellwig
2013-11-04 16:41     ` Anna Schumaker
2013-11-04 17:03       ` Christoph Hellwig
2013-11-04 17:23         ` Anna Schumaker
2013-11-04 18:53           ` Christoph Hellwig
2013-11-04 18:57             ` Anna Schumaker
2013-11-04 19:16             ` Chuck Lever
2013-11-04 19:19               ` Christoph Hellwig
2013-11-04 19:50                 ` Chuck Lever
2013-11-04 19:54                   ` Christoph Hellwig
2013-11-04 19:55                   ` J. Bruce Fields
2013-11-04 20:03                   ` Haynes, Tom
2013-11-04 20:13                     ` Christoph Hellwig
2013-11-05  9:40   ` Christoph Hellwig
2013-11-05 14:23     ` Anna Schumaker
2013-11-05 15:11       ` Christoph Hellwig
2013-10-28 14:57 ` [PATCH 4/4] NFSD: Implement SEEK Anna Schumaker
2013-10-28 21:51   ` J. Bruce Fields
2013-10-29 12:53     ` Anna Schumaker
2013-10-29  7:35   ` Christoph Hellwig
2013-10-29 13:00     ` Anna Schumaker
2013-10-29 13:07       ` Christoph Hellwig
2013-10-29 13:30         ` J. Bruce Fields
2013-11-02 13:48           ` Christoph Hellwig
2013-11-02 14:37             ` J. Bruce Fields
2013-11-02 14:41               ` Christoph Hellwig
2013-11-04 16:46                 ` J. Bruce Fields
2013-11-04 17:05                   ` Christoph Hellwig
2013-11-04 17:22                     ` Chuck Lever
2013-11-05 12:33                       ` Christoph Hellwig
2013-11-04 21:56                   ` Thomas Haynes
2013-11-05  1:03                     ` Christoph Hellwig
2013-11-05  2:07                       ` Haynes, Tom
2013-11-05  8:23                         ` Christoph Hellwig
2013-10-31 16:04   ` Christoph Hellwig
2013-10-31 16:07     ` Anna Schumaker
2013-10-31 16:17     ` Anna Schumaker
2013-10-31 17:13       ` Christoph Hellwig
2013-10-28 14:57 ` [RFC 5/4] NFSD: Add basic CB_OFFLOAD support Anna Schumaker
2013-10-28 21:52   ` J. Bruce Fields
2013-10-29  7:37     ` Christoph Hellwig
2013-10-29 13:36       ` J. Bruce Fields
2013-10-29 13:38         ` Christoph Hellwig
2013-10-29 13:53           ` J. Bruce Fields
2013-10-29 15:11             ` Christoph Hellwig
2013-10-28 20:00 ` [PATCH 0/4] NFSD: Add support for WRITE_PLUS and SEEK Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131102150738.GA21133@infradead.org \
    --to=hch@infradead.org \
    --cc=Bryan.Schumaker@netapp.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).