From: Malahal Naineni <malahal@us.ibm.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Linux NFS mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] SUNRPC: Fix a data corruption issue when retransmitting RPC calls
Date: Mon, 11 Nov 2013 18:15:45 -0600 [thread overview]
Message-ID: <20131112001545.GB31826@us.ibm.com> (raw)
In-Reply-To: <1384212310.7614.29.camel@leira.trondhjem.org>
Myklebust, Trond [Trond.Myklebust@netapp.com] wrote:
> On Mon, 2013-11-11 at 17:15 -0600, Malahal Naineni wrote:
> > Trond Myklebust [Trond.Myklebust@netapp.com] wrote:
> > > @@ -700,13 +707,20 @@ static int xs_tcp_send_request(struct rpc_task *task)
> > > xs_pktdump("packet data:",
> > > req->rq_svec->iov_base,
> > > req->rq_svec->iov_len);
> > > + /* Don't use zero copy if this is a resend. If the RPC call
> > > + * completes while the socket holds a reference to the pages,
> > > + * then we may end up resending corrupted data.
> > > + */
> > > + if (task->tk_flags & RPC_TASK_SENT)
> >
> > How about RPC_WAS_SENT() ?
>
> <shrug>that evaluates to the same</shrug>
Yes, but what is the point of having a macro then?
Regards, Malahal.
prev parent reply other threads:[~2013-11-12 0:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-09 18:20 [PATCH] SUNRPC: Fix a data corruption issue when retransmitting RPC calls Trond Myklebust
2013-11-10 20:33 ` Chuck Lever
2013-11-10 22:18 ` Myklebust, Trond
2013-11-11 23:15 ` Malahal Naineni
2013-11-11 23:25 ` Myklebust, Trond
2013-11-12 0:15 ` Malahal Naineni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112001545.GB31826@us.ibm.com \
--to=malahal@us.ibm.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).