linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Weng Meiling <wengmeiling.weng@huawei.com>
Cc: linux-nfs@vger.kernel.org, Trond.Myklebust@netapp.com,
	davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Li Zefan <lizefan@huawei.com>
Subject: Re: [PATCH] svcrpc: remove the unnecessary evaluation
Date: Wed, 13 Nov 2013 10:56:58 -0500	[thread overview]
Message-ID: <20131113155658.GH28033@fieldses.org> (raw)
In-Reply-To: <527C9160.3070808@huawei.com>

On Fri, Nov 08, 2013 at 03:23:12PM +0800, Weng Meiling wrote:
> 
> From: Weng Meiling <wengmeiling.weng@huawei.com>

Huh.  Looks like that was introduced with "[PATCH] knfsd: make sure
svc_process call the correct pg_authenticate for multi-service port" in
2005.  OK!  Applied.

--b.

> 
> Signed-off-by: Weng Meiling <wengmeiling.weng@huawei.com>
> ---
>  net/sunrpc/svc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index b974571..e7fbe36 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -1104,8 +1104,6 @@ svc_process_common(struct svc_rqst *rqstp, struct kvec *argv, struct kvec *resv)
>  	rqstp->rq_vers = vers = svc_getnl(argv);	/* version number */
>  	rqstp->rq_proc = proc = svc_getnl(argv);	/* procedure number */
> 
> -	progp = serv->sv_program;
> -
>  	for (progp = serv->sv_program; progp; progp = progp->pg_next)
>  		if (prog == progp->pg_prog)
>  			break;
> -- 
> 1.8.3.1
> 
> 
> 
> 

      reply	other threads:[~2013-11-13 15:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <52786417.6090707@huawei.com>
2013-11-08  7:23 ` [PATCH] svcrpc: remove the unnecessary evaluation Weng Meiling
2013-11-13 15:56   ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131113155658.GH28033@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=Trond.Myklebust@netapp.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=wengmeiling.weng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).