From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: sharing protocol defintions between client and server?
Date: Thu, 14 Nov 2013 10:05:46 -0500 [thread overview]
Message-ID: <20131114150546.GA21152@fieldses.org> (raw)
In-Reply-To: <20131113162116.GA14577@infradead.org>
On Wed, Nov 13, 2013 at 08:21:16AM -0800, Christoph Hellwig wrote:
> >From a lot of the recent work it seems like there's basically no
> sharing of protocol definitions between the Linux NFS client and
> server, which seems fairly annoying to me.
What are you thinking of exactly?
I suspect that there could be more sharing.
> Is there a good historic
> reason for this and did we ever attempt to change it? Maybe even
> use some kernel-specific rpcgen variant to generate them directly
> from the spec?
I don't know if anyone's looked into it.
There's a lot of hand-written xdr code (the encoders/decoders
themselves, the maxsz constants in fs/nfs/nfs*xdr.c, the _rsize junk in
fs/nfsd/nfs4proc.c, ...). It seems error-prone to me though I can't
recall if we've had a lot of bugs there in practice.
--b.
next prev parent reply other threads:[~2013-11-14 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 16:21 sharing protocol defintions between client and server? Christoph Hellwig
2013-11-14 15:05 ` J. Bruce Fields [this message]
2013-11-14 16:40 ` Christoph Hellwig
2013-11-14 19:35 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114150546.GA21152@fieldses.org \
--to=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).