From: Christoph Hellwig <hch@infradead.org>
To: Trond Myklebust <trondmy@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 6/7] nfs: take i_mutex during direct I/O reads
Date: Fri, 15 Nov 2013 07:37:19 -0800 [thread overview]
Message-ID: <20131115153719.GA5443@infradead.org> (raw)
In-Reply-To: <33A9F8E7-A6DE-435C-AC7A-39472E6A8E90@gmail.com>
On Fri, Nov 15, 2013 at 10:34:52AM -0500, Trond Myklebust wrote:
> > With the current locking model that will require the i_mutex in both
> > read and write around the i_dio_count increment. The XFS model avoids
> > taking an exclusive lock for the direct I/O fast path.
> >
>
> Is that the xfs_ilock vs xfs_rw_ilock code?
xfs_rw_ilock is where you should lock, that are the helpers around
the xfs iolock which is the shared/exclusive lock and the i_mutex
which we still have to take in the exclusive case as the VFS expects it.
next prev parent reply other threads:[~2013-11-15 15:37 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 16:50 [PATCH 0/7] direct I/O fixes Christoph Hellwig
2013-11-14 16:50 ` [PATCH 1/7] nfs: fix size updates for aio writes Christoph Hellwig
2013-11-14 16:50 ` [PATCH 2/7] nfs: defer inode_dio_done call until size update is done Christoph Hellwig
2013-11-14 16:50 ` [PATCH 3/7] nfs: increment i_dio_count for reads, too Christoph Hellwig
2013-11-14 16:50 ` [PATCH 4/7] nfs: merge nfs_direct_read into nfs_file_direct_read Christoph Hellwig
2013-11-14 16:50 ` [PATCH 5/7] nfs: merge nfs_direct_write into nfs_file_direct_write Christoph Hellwig
2013-11-14 16:50 ` [PATCH 6/7] nfs: take i_mutex during direct I/O reads Christoph Hellwig
2013-11-14 17:00 ` Chuck Lever
2013-11-15 14:29 ` Christoph Hellwig
2013-11-14 20:43 ` Trond Myklebust
2013-11-15 14:32 ` Christoph Hellwig
2013-11-15 15:23 ` Trond Myklebust
2013-11-15 15:25 ` Christoph Hellwig
2013-11-15 15:34 ` Trond Myklebust
2013-11-15 15:37 ` Christoph Hellwig [this message]
2013-11-15 16:00 ` Trond Myklebust
2013-11-14 16:50 ` [PATCH 7/7] nfs: page cache invalidation for dio Christoph Hellwig
2013-11-14 18:35 ` Jeff Layton
2013-11-15 14:28 ` Christoph Hellwig
2013-11-15 14:52 ` Jeff Layton
2013-11-15 15:02 ` Christoph Hellwig
2013-11-15 15:33 ` Jeff Layton
2014-01-21 19:21 ` Jeff Layton
2014-01-22 8:24 ` Christoph Hellwig
2014-01-22 12:04 ` Jeff Layton
2014-01-24 15:50 ` Jeff Layton
2014-01-24 15:52 ` Jeff Layton
2014-01-24 17:11 ` Trond Myklebust
2014-01-24 17:29 ` Jeff Layton
2014-01-24 17:40 ` Trond Myklebust
2014-01-24 18:00 ` Jeff Layton
2014-01-24 18:46 ` Trond Myklebust
2014-01-24 21:21 ` Jeff Layton
2014-01-25 0:39 ` Trond Myklebust
2014-01-25 0:54 ` Jeff Layton
2014-01-25 1:05 ` Trond Myklebust
2014-01-25 1:11 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115153719.GA5443@infradead.org \
--to=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).