linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Bruce Fields <bfields@fieldses.org>,
	Steve Dickson <steved@redhat.com>,
	"Linux NFS Mailing List" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] gssd: don't let parent exit until child has a chance to scan directory once
Date: Mon, 18 Nov 2013 11:53:59 -0500	[thread overview]
Message-ID: <20131118115359.21e5f562@tlielax.poochiereds.net> (raw)
In-Reply-To: <B3D4C4F6-511B-4114-9C2F-196A08F3DD54@netapp.com>

On Mon, 18 Nov 2013 16:48:14 +0000
"Myklebust, Trond" <Trond.Myklebust@netapp.com> wrote:

> 
> On Nov 18, 2013, at 11:38, J. Bruce Fields <bfields@fieldses.org> wrote:
> 
> > On Fri, Nov 15, 2013 at 02:15:31PM -0500, Jeff Layton wrote:
> >> With some proposed kernel changes, it won't even attempt to upcall
> >> sometimes if it doesn't appear that gssd is running. This means that
> >> we have a theoretical race between gssd starting up at boot time and
> >> the init process attempting to mount kerberized filesystems.
> >> 
> >> Fix this by switching gssd to use mydaemon() and having the child
> >> only release the parent after it has processed the directory once.
> > 
> > Makes sense to me, thanks--ACK.
> 
> We now appear to have 2 more or less identical copies of mydaemon in nfs-utils (one in utils/gssd/svcgssd.c and one in utils/idmapd/idmapd.c). Time to make it a common library function?
> 

See patch 1 in the series. That's exactly what I did...

-- 
Jeff Layton <jlayton@redhat.com>

  reply	other threads:[~2013-11-18 16:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15 19:15 [PATCH 0/2] gssd: prevent race between gssd startup and fstab mounts Jeff Layton
2013-11-15 19:15 ` [PATCH 1/2] nfs-utils: consolidate mydaemon() and release_parent() implementations Jeff Layton
2013-11-20 21:24   ` Steve Dickson
2013-11-15 19:15 ` [PATCH 2/2] gssd: don't let parent exit until child has a chance to scan directory once Jeff Layton
2013-11-18 16:38   ` J. Bruce Fields
2013-11-18 16:48     ` Myklebust, Trond
2013-11-18 16:53       ` Jeff Layton [this message]
2013-11-20 21:24   ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131118115359.21e5f562@tlielax.poochiereds.net \
    --to=jlayton@redhat.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).