From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] nfsd: split up nfsd_setattr
Date: Mon, 18 Nov 2013 09:39:18 -0500 [thread overview]
Message-ID: <20131118143918.GB3203@fieldses.org> (raw)
In-Reply-To: <20131118141624.GA15744@infradead.org>
On Mon, Nov 18, 2013 at 06:16:24AM -0800, Christoph Hellwig wrote:
> On Mon, Nov 18, 2013 at 09:10:31AM -0500, J. Bruce Fields wrote:
> > On Mon, Nov 18, 2013 at 05:07:30AM -0800, Christoph Hellwig wrote:
> > > Split out two helpers to make the code more readable and easier to verify
> > > for correctness.
> >
> > Thanks, both queued up for 2.14.
>
> The write counter leak on a break_lease failure is quite serious,
> given that nfsd_break_lease passes O_NONBLOCK and thus remote users
> can arbitrarily trigger it.
Oops, I read too quickly and thought it was just cleanup.
Looks like I introduced that bug into 2.6.38 with
6a76bebefe15d9a08864f824d7f8d5beaf37c997 "nfsd4: break lease on nfsd
setattr"
OK, added a sentence saying that to the second path and I'll pass it
along with stable cc:'s after some testing.
--b.
prev parent reply other threads:[~2013-11-18 14:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 13:07 [PATCH 1/2] nfsd: split up nfsd_setattr Christoph Hellwig
2013-11-18 13:07 ` [PATCH 2/2] nfsd: make sure to balance get/put_write_access Christoph Hellwig
2013-11-18 14:10 ` [PATCH 1/2] nfsd: split up nfsd_setattr J. Bruce Fields
2013-11-18 14:16 ` Christoph Hellwig
2013-11-18 14:39 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118143918.GB3203@fieldses.org \
--to=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).